Refactor verify: split session validation and validateAndDispatchMsg (#939)#1088
Open
wilson-zh wants to merge 2 commits intoquickfix-j:masterfrom
Open
Refactor verify: split session validation and validateAndDispatchMsg (#939)#1088wilson-zh wants to merge 2 commits intoquickfix-j:masterfrom
wilson-zh wants to merge 2 commits intoquickfix-j:masterfrom
Conversation
Member
|
Hi @wilson-zh , thanks for the PR. There is an error in the tests: The builds were in an endless loop, I just cancelled them. Could you please take a look at it? Thank you |
chrjohn
requested changes
Dec 2, 2025
3dcb78b to
02a5da6
Compare
02a5da6 to
2cc13c1
Compare
Member
|
@philipwhiuk do you have anything to add? You created the initial issue #939 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #939: Remove unreachable session verification logic
Refactor
Session/verifyby movingfromCallBackcall outsideverify, therefore preserves: