Rename Recipe Packs recipeKind/recipeLocation to kind/source by willdavsmith · Pull Request #12104 · radius-project/radius

willdavsmith · 2026-06-15T16:52:23Z

Description

Updates the Radius.Core/recipePacks@2025-08-01-preview schema for #11879, ahead of public launch:

Rename recipeKind and recipeLocation to kind and source in Recipe Packs #11879: rename RecipeDefinition.recipeKind → kind and recipeLocation → source. parameters/outputs stay unprefixed.

Changes are made in the TypeSpec source of truth and propagated through the codegen pipeline; downstream OpenAPI/swagger, the Go SDK (zz_generated_*), and Bicep types are regenerated. Hand-written datamodel, versioned conversion, internal recipes types, configloader, CLI display, tests, and fixtures are updated to match.

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #11879

Related PRs (merge together)

This is a breaking schema change for a preview API, so the producer/consumer repos must ship alongside this PR:

resource-types-contrib: Rename recipe pack recipeKind/recipeLocation to kind/source resource-types-contrib#182 (recipe pack generator + sample)
dashboard: Align recipe pack consumer with renamed kind/source schema dashboard#288 (API consumer)
docs: Update Radius.Core/recipePacks reference for kind/source docs#1919 (reference + spell dictionary)

Warning

Breaking change (preview API): recipeKind/recipeLocation are renamed to kind/source for Radius.Core/recipePacks@2025-08-01-preview. Existing preview recipe packs must be re-authored with the new field names. This is intentionally landed during preview, before public launch, to avoid a breaking change post-GA.

Contributor checklist

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
A design document is added or updated under eng/design-notes/, if new APIs are being introduced.
- Not applicable
A PR for resource-types-contrib is created, if resource types or recipes are affected.
- Yes
A PR for dashboard is created, if the Radius Dashboard is affected.
- Yes
A PR for the documentation repository is created, if the changes affect documentation or user-facing behavior.
- Yes

github-actions · 2026-06-15T16:52:44Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot

Pull request overview

Updates the Radius.Core/recipePacks@2025-08-01-preview contract to remove redundant recipe* prefixes (recipeKind→kind, recipeLocation→source) and introduces an optional version field intended for Terraform registry modules, plumbing it through the internal recipe/environment types and Terraform module config generation.

Changes:

Rename Recipe Pack recipe fields to kind/source across TypeSpec → OpenAPI/Swagger → generated Go models → CLI/tests/fixtures.
Add optional version to RecipeDefinition and wire it into EnvironmentDefinition.TemplateVersion for Terraform module config generation.
Regenerate/update downstream artifacts (Swagger examples, Bicep types, SDK serde) and adjust functional/CLI/controller tests and fixtures.

Reviewed changes

Copilot reviewed 34 out of 37 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
typespec/Radius.Core/recipePacks.tsp	Source-of-truth schema rename to `kind`/`source` and adds optional `version`.
typespec/Radius.Core/examples/2025-08-01-preview/RecipePacks_ListByScope.json	Update example payload keys to `kind`/`source`.
typespec/Radius.Core/examples/2025-08-01-preview/RecipePacks_List.json	Update example payload keys to `kind`/`source`.
typespec/Radius.Core/examples/2025-08-01-preview/RecipePacks_Get.json	Update example payload keys to `kind`/`source`.
typespec/Radius.Core/examples/2025-08-01-preview/RecipePacks_CreateOrUpdate.json	Update example payload keys and demonstrates Terraform `version`.
test/functional-portable/dynamicrp/noncloud/resources/testdata/tfbicep-combined-test.bicep	Update Bicep testdata to `kind`/`source`.
test/functional-portable/dynamicrp/noncloud/resources/testdata/terraformconfig-redis-test.bicep	Update Bicep testdata to `kind`/`source`.
test/functional-portable/dynamicrp/noncloud/resources/testdata/recipepacks-test.bicep	Update Bicep testdata to `kind`/`source`.
test/functional-portable/dynamicrp/noncloud/resources/testdata/recipepacks-test-no-provider.bicep	Update Bicep testdata to `kind`/`source`.
test/functional-portable/cli/noncloud/testdata/corerp-recipe-pack-test.bicep	Update CLI functional test template to `kind`/`source`.
swagger/specification/radius/resource-manager/Radius.Core/preview/2025-08-01-preview/openapi.json	Regenerated OpenAPI for renamed fields + new `version` field.
swagger/specification/radius/resource-manager/Radius.Core/preview/2025-08-01-preview/examples/RecipePacks_ListByScope.json	Regenerated Swagger example keys to `kind`/`source`.
swagger/specification/radius/resource-manager/Radius.Core/preview/2025-08-01-preview/examples/RecipePacks_Get.json	Regenerated Swagger example keys to `kind`/`source`.
swagger/specification/radius/resource-manager/Radius.Core/preview/2025-08-01-preview/examples/RecipePacks_CreateOrUpdate.json	Regenerated Swagger example keys and shows Terraform `version`.
pkg/ucp/initializer/service_test.go	Updates schema-hydration assertions for `kind`/`source`.
pkg/recipes/types.go	Renames internal recipe definition fields and adds `Version`.
pkg/recipes/configloader/environment.go	Maps recipe pack `version` → `EnvironmentDefinition.TemplateVersion`.
pkg/corerp/frontend/controller/recipepacks/testdata/recipepack_datamodel.json	Updates controller testdata JSON to `kind`/`source`.
pkg/corerp/frontend/controller/recipepacks/createorupdaterecipepack_test.go	Updates controller tests for renamed fields in v20250801preview models/datamodel.
pkg/corerp/frontend/controller/environments/v20250801preview/createorupdateenvironment_test.go	Updates environment validation tests for renamed fields.
pkg/corerp/datamodel/recipepack.go	Datamodel rename to `kind`/`source` and adds `version,omitempty`.
pkg/corerp/datamodel/converter/recipepack_converter_test.go	Updates converter tests to renamed fields.
pkg/corerp/api/v20250801preview/zz_generated_models.go	Regenerated SDK model: `Kind`, `Source`, optional `Version`.
pkg/corerp/api/v20250801preview/zz_generated_models_serde.go	Regenerated JSON serde for `kind`/`source`/`version`.
pkg/corerp/api/v20250801preview/testdata/recipepackresourcedatamodel.json	Updates conversion fixture JSON keys, includes `version`.
pkg/corerp/api/v20250801preview/testdata/recipepackresource.json	Updates conversion fixture JSON keys, includes `version`.
pkg/corerp/api/v20250801preview/recipepack_conversion.go	Updates versioned↔datamodel conversion to map `kind`/`source`/`version`.
pkg/corerp/api/v20250801preview/recipepack_conversion_test.go	Extends conversion tests to cover renamed fields and `version`.
pkg/cli/test_client_factory/radius_core.go	Updates fake server payloads to `kind`/`source`.
pkg/cli/recipepack/recipepack.go	Updates default recipe pack creation to set `Kind`/`Source`.
pkg/cli/recipepack/recipepack_test.go	Updates tests for renamed fields.
pkg/cli/objectformats/objectformats.go	Updates table headings/JSONPaths to `Kind`/`Source`.
pkg/cli/cmd/recipepack/show/show_test.go	Updates recipe pack show command test payloads.
pkg/cli/cmd/recipepack/show/display.go	Updates display labels and prints `Version` when present.
pkg/cli/cmd/env/show/preview/show.go	Updates env show preview recipe projection to `Kind`/`Source`.
pkg/cli/cmd/env/show/preview/show_test.go	Updates env show preview tests for renamed fields.
hack/bicep-types-radius/generated/radius/radius.core/2025-08-01-preview/types.json	Regenerated Bicep types to expose `kind`/`source`/`version`.

Files not reviewed (2)

pkg/corerp/api/v20250801preview/zz_generated_models.go: Generated file
pkg/corerp/api/v20250801preview/zz_generated_models_serde.go: Generated file

codecov · 2026-06-15T17:06:14Z

Codecov Report

❌ Patch coverage is 53.62319% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.57%. Comparing base (0e1fe65) to head (737a933).

Files with missing lines	Patch %	Lines
pkg/recipes/configloader/environment.go	0.00%	12 Missing ⚠️
pkg/cli/test_client_factory/radius_core.go	0.00%	10 Missing ⚠️
pkg/cli/objectformats/objectformats.go	0.00%	8 Missing ⚠️
pkg/cli/cmd/env/show/preview/show.go	83.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12104      +/-   ##
==========================================
- Coverage   52.58%   52.57%   -0.01%     
==========================================
  Files         737      737              
  Lines       47310    47324      +14     
==========================================
+ Hits        24878    24882       +4     
- Misses      20092    20100       +8     
- Partials     2340     2342       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-06-15T17:06:17Z

Unit Tests

2 files ±0 440 suites ±0 7m 23s ⏱️ -15s
5 405 tests ±0 5 403 ✅ ±0 2 💤 ±0 0 ❌ ±0
6 585 runs ±0 6 583 ✅ ±0 2 💤 ±0 0 ❌ ±0

Results for commit 737a933. ± Comparison against base commit 0e1fe65.

♻️ This comment has been updated with latest results.

Implements #11879 for Radius.Core/recipePacks@2025-08-01-preview. Renames RecipeDefinition.recipeKind -> kind and recipeLocation -> source. parameters/outputs stay unprefixed. Updates the TypeSpec source of truth and regenerates OpenAPI/swagger, the Go SDK, and Bicep types. Also updates the datamodel, versioned conversion, internal recipes types, configloader, CLI display, tests, and fixtures. BREAKING CHANGE: recipeKind/recipeLocation are renamed to kind/source for the Radius.Core/recipePacks preview API. Existing preview recipe packs must be re-authored with the new field names. Signed-off-by: willdavsmith <willdavsmith@gmail.com>

The Radius.Core/recipePacks@2025-08-01-preview schema renames RecipeDefinition.recipeKind -> kind and recipeLocation -> source. Updates the dashboard to consume the new field names. Companion to radius-project/radius#12104 (implements radius-project/radius#11879).

@doc

Updates the Radius.Core/recipePacks@2025-08-01-preview reference to match the renamed schema: RecipeDefinition.recipeKind -> kind and recipeLocation -> source (radius-project/radius#11879). Refreshes the plainHttp/source descriptions to match the updated Bicep type @doc strings, and removes the now-unused recipeKind/recipeLocation entries from the spell dictionary. Companion to radius-project/radius#12104.

…cks-kind-source-version Signed-off-by: willdavsmith <willdavsmith@gmail.com> # Conflicts: # pkg/cli/recipepack/recipepack.go # pkg/cli/recipepack/recipepack_test.go # pkg/corerp/api/v20250801preview/zz_generated_models.go

The Radius.Core/recipePacks@2025-08-01-preview schema renames RecipeDefinition.recipeKind -> kind and recipeLocation -> source. Updates the dashboard to consume the new field names. Companion to radius-project/radius#12104 (implements radius-project/radius#11879). Signed-off-by: willdavsmith <willdavsmith@gmail.com>

@doc

Updates the Radius.Core/recipePacks@2025-08-01-preview reference to match the renamed schema: RecipeDefinition.recipeKind -> kind and recipeLocation -> source (radius-project/radius#11879). Refreshes the plainHttp/source descriptions to match the updated Bicep type @doc strings, and removes the now-unused recipeKind/recipeLocation entries from the spell dictionary. Companion to radius-project/radius#12104. Signed-off-by: willdavsmith <willdavsmith@gmail.com>

Address PR review feedback: - Lowercase recipe kind fixture/assertion values ("Bicep"/"Terraform" -> "bicep"/"terraform") to match the schema-valid RecipeKind enum. - Rename stale recipeKindProperty/recipeSourceProperty test variables to kindProperty/sourceProperty to match the renamed schema properties. Signed-off-by: willdavsmith <willdavsmith@gmail.com>

Copilot

Pull request overview

Copilot reviewed 34 out of 37 changed files in this pull request and generated 1 comment.

Files not reviewed (2)

pkg/corerp/api/v20250801preview/zz_generated_models.go: Generated file
pkg/corerp/api/v20250801preview/zz_generated_models_serde.go: Generated file

Address PR review feedback: recipepacks-test-by-name.bicep (used by Test_RecipePacks_ByName_Deployment) still used the legacy recipeKind/recipeLocation properties, which would fail against the renamed kind/source schema. Update it to match the renamed fields. Signed-off-by: willdavsmith <willdavsmith@gmail.com>

Copilot

Pull request overview

Copilot reviewed 35 out of 38 changed files in this pull request and generated 1 comment.

Files not reviewed (2)

pkg/corerp/api/v20250801preview/zz_generated_models.go: Generated file
pkg/corerp/api/v20250801preview/zz_generated_models_serde.go: Generated file

Address PR review feedback: docs/architecture/extensibility.md is living architecture documentation, so update its recipe pack YAML example and prose references from recipeKind/recipeLocation to the renamed kind/source fields. Dated design notes under eng/design-notes are left unchanged as point-in-time records. Signed-off-by: willdavsmith <willdavsmith@gmail.com>

…cks-kind-source-version Signed-off-by: willdavsmith <willdavsmith@gmail.com>

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

lakshmimsft · 2026-06-22T19:29:47Z

Do we need updates in resource-types-contrb repo after this change goes in?

willdavsmith · 2026-06-22T19:36:07Z

Do we need updates in resource-types-contrb repo after this change goes in?

yes, here's the PR: https://github.com/radius-project/resource-types-contrib/pull/182/changes

The Radius.Core/recipePacks@2025-08-01-preview schema renames RecipeDefinition.recipeKind -> kind and recipeLocation -> source. Updates the dashboard to consume the new field names. Companion to radius-project/radius#12104 (implements radius-project/radius#11879). Signed-off-by: willdavsmith <willdavsmith@gmail.com>

@doc

Updates the Radius.Core/recipePacks@2025-08-01-preview reference to match the renamed schema: RecipeDefinition.recipeKind -> kind and recipeLocation -> source (radius-project/radius#11879). Refreshes the plainHttp/source descriptions to match the updated Bicep type @doc strings, and removes the now-unused recipeKind/recipeLocation entries from the spell dictionary. Companion to radius-project/radius#12104. Signed-off-by: willdavsmith <willdavsmith@gmail.com>

The Radius.Core/recipePacks@2025-08-01-preview schema renames RecipeDefinition.recipeKind -> kind and recipeLocation -> source. Updates the dashboard to consume the new field names. Companion to radius-project/radius#12104 (implements radius-project/radius#11879). Signed-off-by: willdavsmith <willdavsmith@gmail.com>

@doc

Updates the Radius.Core/recipePacks@2025-08-01-preview reference to match the renamed schema: RecipeDefinition.recipeKind -> kind and recipeLocation -> source (radius-project/radius#11879). Refreshes the plainHttp/source descriptions to match the updated Bicep type @doc strings, and removes the now-unused recipeKind/recipeLocation entries from the spell dictionary. Companion to radius-project/radius#12104. Signed-off-by: willdavsmith <willdavsmith@gmail.com>

radius-functional-tests · 2026-06-22T22:15:48Z

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details

Name	Value
Repository	radius-project/radius
Commit ref	`737a933`
Unique ID	func87d5009743
Image tag	pr-func87d5009743

KinD: v0.29.0
Dapr: 1.14.4
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func87d5009743
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func87d5009743
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func87d5009743
controller test image location: ghcr.io/radius-project/dev/controller:pr-func87d5009743
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func87d5009743
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

Copilot AI review requested due to automatic review settings June 15, 2026 16:52

willdavsmith requested review from a team as code owners June 15, 2026 16:52

willdavsmith added pr:breaking-change pr:important labels Jun 15, 2026

Copilot started reviewing on behalf of willdavsmith June 15, 2026 16:52 View session

willdavsmith mentioned this pull request Jun 15, 2026

Rename recipe pack recipeKind/recipeLocation to kind/source radius-project/resource-types-contrib#182

Open

Copilot AI reviewed Jun 15, 2026

View reviewed changes

This was referenced Jun 15, 2026

Align recipe pack consumer with renamed kind/source schema radius-project/dashboard#287

Closed

Update Radius.Core/recipePacks reference for kind/source radius-project/docs#1919

Open

willdavsmith force-pushed the willdavsmith/recipepacks-kind-source-version branch from 8495442 to 20b784b Compare June 15, 2026 18:18

willdavsmith changed the title ~~Rename Recipe Packs recipeKind/recipeLocation to kind/source and add version field~~ Rename Recipe Packs recipeKind/recipeLocation to kind/source Jun 15, 2026

lakshmimsft requested a review from Reshrahim June 15, 2026 18:26

willdavsmith marked this pull request as draft June 15, 2026 18:27

willdavsmith mentioned this pull request Jun 15, 2026

Align recipe pack consumer with renamed kind/source schema radius-project/dashboard#288

Open

willdavsmith force-pushed the willdavsmith/recipepacks-kind-source-version branch from 59509a8 to bc993a7 Compare June 22, 2026 17:07

willdavsmith marked this pull request as ready for review June 22, 2026 17:17

willdavsmith requested a review from Copilot June 22, 2026 17:17

Copilot started reviewing on behalf of willdavsmith June 22, 2026 17:17 View session

willdavsmith requested a review from Copilot June 22, 2026 18:01

Copilot started reviewing on behalf of willdavsmith June 22, 2026 18:02 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Comment thread typespec/Radius.Core/recipePacks.tsp

willdavsmith requested a review from Copilot June 22, 2026 18:11

Copilot started reviewing on behalf of willdavsmith June 22, 2026 18:12 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Comment thread typespec/Radius.Core/recipePacks.tsp

nithyatsu previously approved these changes Jun 22, 2026

View reviewed changes

willdavsmith dismissed nithyatsu’s stale review via 50d4558 June 22, 2026 18:18

willdavsmith added 2 commits June 22, 2026 11:44

Merge remote-tracking branch 'origin/main' into willdavsmith/recipepa…

578b53f

…cks-kind-source-version Signed-off-by: willdavsmith <willdavsmith@gmail.com>

Regenerate corerp 2025-08-01-preview models after merge

4d84465

Signed-off-by: willdavsmith <willdavsmith@gmail.com>

nithyatsu approved these changes Jun 22, 2026

View reviewed changes

lakshmimsft reviewed Jun 22, 2026

View reviewed changes

Comment thread pkg/cli/cmd/env/show/preview/show.go

lakshmimsft approved these changes Jun 22, 2026

View reviewed changes

lakshmimsft enabled auto-merge (squash) June 22, 2026 19:58

lakshmimsft disabled auto-merge June 22, 2026 19:58

willdavsmith force-pushed the willdavsmith/recipepacks-kind-source-version branch from ef4f7c2 to 4d84465 Compare June 22, 2026 20:20

Merge branch 'main' into willdavsmith/recipepacks-kind-source-version

df80756

willdavsmith enabled auto-merge (squash) June 22, 2026 20:22

willdavsmith added 2 commits June 22, 2026 14:40

Merge branch 'main' into willdavsmith/recipepacks-kind-source-version

abcae6b

Merge branch 'main' into willdavsmith/recipepacks-kind-source-version

737a933

Conversation

willdavsmith commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Related PRs (merge together)

Contributor checklist

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

lakshmimsft commented Jun 22, 2026

Uh oh!

Uh oh!

willdavsmith commented Jun 22, 2026

Uh oh!

radius-functional-tests Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

willdavsmith commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

codecov Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

radius-functional-tests Bot commented Jun 22, 2026 •

edited

Loading