feat: add Tinker-compatible training API - #2007
Open
yushengsu-thu wants to merge 1 commit into
Open
Conversation
yushengsu-thu
requested review from
fzyzcjy,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
July 30, 2026 16:37
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServiceClient,TrainingClient, andSamplingClientroutesCompatibility
Validation
pytest -q tests/fast: 4081 passed, 22 skipped; one Ray dashboard test collided with an already-running external Ray cluster and passed in isolation after stopping that clustergit diff --checkpassedTested dependency heads
main:2cb59235176a170480765e762e85a952e6ba72b7sglang-miles:3003d70f680d41c59d1b7acbf65cb47795dfd19ebridge:7f0fb3456f8ffe47599b5fd167b454605d85f932