[Ganesh/Abhishek] - fixed bug in specified color#25
Open
GaneshSPatil wants to merge 1 commit intorafeca:masterfrom
Open
[Ganesh/Abhishek] - fixed bug in specified color#25GaneshSPatil wants to merge 1 commit intorafeca:masterfrom
GaneshSPatil wants to merge 1 commit intorafeca:masterfrom
Conversation
What changes have you made? Changes made while printing json with user specified colors Previously user was able to specify any color(invalid color) because of which all the data was printing as undefined Added a check before printing data that if the user specified color is invalid then use the default colors. Why do we need this change? To print the data with valid options and color schemes Files Modified: modified: lib/prettyjson.js modified: test/prettyjson_spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes have you made?
Changes made while printing json with user specified colors
Previously user was able to specify any color(invalid color)
because of which all the data was printing as undefined
Added a check before printing data that if the user specified color
is invalid then use the default colors.
Why do we need this change?
To print the data with valid options and color schemes
Files Modified: