Remove Laravel optimize:clear from startup - #559
Open
radiantjade wants to merge 1 commit into
Open
Conversation
Railpack should warm Laravel optimization caches without running optimize:clear on every container start. The clear command can flush the default app cache store, which is surprising during deploys and restarts. Constraint: Laravel startup still needs storage link and optimize warmup behavior. Rejected: Keep optimize:clear before optimize | can clear production runtime cache. Confidence: medium Scope-risk: narrow Tested: go test ./core/providers/php Tested: go test ./core -run 'TestGenerateBuildPlanForExamples/php-laravel' Tested: go test ./core -run 'TestGenerateBuildPlanForExamples/php-vanilla' Not-tested: go test ./core currently has unrelated Caddy snapshot drift from caddy@2.11.2 to caddy@2.11.3 in Node/staticfile examples.
iloveitaly
requested changes
May 30, 2026
iloveitaly
left a comment
iloveitaly
left a comment
Collaborator
There was a problem hiding this comment.
this looks like a great change. If you can fix CI failures I'm happy to merge this in!
Collaborator
|
Friendly ping here! I'm making some improvements to the PHP support here soon, so would love to get this change in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #555.
This removes
php artisan optimize:clearfrom the Laravel container startup script while keepingstorage:linkandoptimize. Runningoptimize:clearon every start can flush Laravel's default cache store during deploys and restarts; startup should warm optimization caches without clearing runtime cache first.Verification:
go test ./core/providers/phpgo test ./core -run 'TestGenerateBuildPlanForExamples/php-laravel'\n-go test ./core -run 'TestGenerateBuildPlanForExamples/php-vanilla'\n-git diff --check\n\nNote:go test ./corecurrently fails on unrelated Node/staticfile snapshots because generated Caddy commands now resolvecaddy@2.11.3while existing snapshots expectcaddy@2.11.2. The PHP-focused tests above pass.