-
Notifications
You must be signed in to change notification settings - Fork 1
update forge #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update forge #162
Changes from all commits
86eb157
b4e6db6
c4bd8f0
7c79bca
44e0ac4
e54d83e
98b846d
0e93d7e
e7a3183
1a679bb
1a54995
3cb755b
2ac7507
9e184c0
8e5dd1d
e939702
111ab64
a53df89
d8ab035
ab93d0e
62d1758
7f8af27
e42363a
4485341
7793013
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,6 +54,10 @@ jobs: | |
| - name: Run ${{ matrix.task }} | ||
| env: | ||
| ETH_RPC_URL: ${{ secrets.CI_DEPLOY_SEPOLIA_RPC_URL || vars.CI_DEPLOY_SEPOLIA_RPC_URL }} | ||
| CI_FORK_ARB_RPC_URL: ${{ secrets.RPC_URL_ARBITRUM_FORK || vars.RPC_URL_ARBITRUM_FORK || '' }} | ||
| CI_FORK_ETH_RPC_URL: ${{ secrets.RPC_URL_ETHEREUM_FORK || vars.RPC_URL_ETHEREUM_FORK || '' }} | ||
| CI_FORK_BASE_RPC_URL: ${{ secrets.RPC_URL_BASE_FORK || vars.RPC_URL_BASE_FORK || '' }} | ||
| CI_FORK_FLARE_RPC_URL: ${{ secrets.RPC_URL_FLARE_FORK || vars.RPC_URL_FLARE_FORK || '' }} | ||
|
Comment on lines
55
to
60
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cd /tmp && find . -name "rainix.yaml" -type f 2>/dev/null | head -5Repository: rainlanguage/rain.math.float Length of output: 54 🏁 Script executed: find . -path "*/.github/workflows/rainix.yaml" -type fRepository: rainlanguage/rain.math.float Length of output: 103 🏁 Script executed: git ls-files | grep -E "(rainix|workflows)" | head -20Repository: rainlanguage/rain.math.float Length of output: 258 🏁 Script executed: cat -n .github/workflows/rainix.yaml | sed -n '45,70p'Repository: rainlanguage/rain.math.float Length of output: 1583 🏁 Script executed: rg -n "CI_FORK_ETH_RPC_URL|CI_FORK_FLARE_RPC_URL" --type bash --type shell --type nix --type rust --type ts --type jsRepository: rainlanguage/rain.math.float Length of output: 100 🏁 Script executed: rg -rn "CI_FORK_ETH_RPC_URL|CI_FORK_FLARE_RPC_URL"Repository: rainlanguage/rain.math.float Length of output: 245 🏁 Script executed: fd -e nix | head -20Repository: rainlanguage/rain.math.float Length of output: 81 🏁 Script executed: git ls-files | grep -E "\.(nix|rs|ts|js|sh)$" | grep -v node_modules | head -30Repository: rainlanguage/rain.math.float Length of output: 243 🏁 Script executed: rg "CI_FORK" -A 2 -B 2Repository: rainlanguage/rain.math.float Length of output: 1204 🏁 Script executed: cat -n flake.nix | head -100Repository: rainlanguage/rain.math.float Length of output: 1520 🏁 Script executed: git ls-files | grep -E "test|spec" | grep -E "\.(sol|ts|js|sh|nix)$" | head -20Repository: rainlanguage/rain.math.float Length of output: 930 🏁 Script executed: cat -n test/src/lib/deploy/LibDecimalFloatDeploy.t.solRepository: rainlanguage/rain.math.float Length of output: 1687 🏁 Script executed: rg "vm.envString|vm.envOpt" -A 2 -B 2Repository: rainlanguage/rain.math.float Length of output: 940 🏁 Script executed: cat -n test/src/lib/deploy/LibDecimalFloatDeploy.t.sol | sed -n '10,36p'Repository: rainlanguage/rain.math.float Length of output: 1284 🌐 Web query:
💡 Result: In Foundry/Forge cheatcodes,
If you want “unset → default” (instead of reverting), use Sources: [1] [2] [3] Guard against empty fork RPC URLs to prevent failures with empty strings. Tests use 🔧 Suggested guard to unset empty values before running- run: nix develop -c ${{ matrix.task }}
+ run: |
+ if [ -z "$CI_FORK_ETH_RPC_URL" ]; then unset CI_FORK_ETH_RPC_URL; fi
+ if [ -z "$CI_FORK_FLARE_RPC_URL" ]; then unset CI_FORK_FLARE_RPC_URL; fi
+ nix develop -c ${{ matrix.task }}🤖 Prompt for AI Agents |
||
| ETHERSCAN_API_KEY: ${{ secrets.EXPLORER_VERIFICATION_KEY }} | ||
| DEPLOY_BROADCAST: "" | ||
| DEPLOY_VERIFIER: "" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,3 +5,4 @@ target | |
| temp | ||
| dist | ||
| node_modules | ||
| .env | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
| { | ||
| "lib/forge-std": { | ||
| "rev": "b8f065fda83b8cd94a6b2fec8fcd911dc3b444fd" | ||
| "rev": "1801b0541f4fda118a10798fd3486bb7051c5dd6" | ||
| }, | ||
| "lib/rain.datacontract": { | ||
| "rev": "061bf7cd63496ccbe4f74bcd0c48715883c1c3cb" | ||
| "rev": "82590300cf768b6c5efc8b92c64b7f402bd34bee" | ||
| }, | ||
| "lib/rain.math.fixedpoint": { | ||
| "rev": "1752e9fbd635901ac7eb177699681ed97290e12e" | ||
| "rev": "8308cbb6da0e231c6f3437f1861e66eff7ea2b00" | ||
| }, | ||
| "lib/rain.sol.codegen": { | ||
| "rev": "bd7993b3f6b301e5a667ff687f25b80fdda878cd" | ||
| }, | ||
| "lib/rain.string": { | ||
| "rev": "0b1ca08aed6d9c06b83fe127a7d20ee7002ead28" | ||
| "rev": "488f237cd59874e4eb91b5a4f747bd57578fec7f" | ||
| } | ||
| } |
| +78 −78 | .gas-snapshot | |
| +1 −0 | REUSE.toml | |
| + − | audit/protofire-rain.math.fixedpoint.jan-2025.pdf | |
| +38 −21 | flake.lock | |
| +3 −3 | foundry.lock | |
| +1 −1 | lib/forge-std | |
| +1 −1 | lib/rain.math.saturating | |
| +1 −1 | lib/rain.string | |
| +2 −0 | src/lib/LibWillOverflow.sol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
rg -n 'CI_FORK_(ETH|FLARE)_RPC_URL' --type yaml --type ts --type js --type shRepository: rainlanguage/rain.math.float
Length of output: 54
🏁 Script executed:
Repository: rainlanguage/rain.math.float
Length of output: 289
🏁 Script executed:
Repository: rainlanguage/rain.math.float
Length of output: 912
🏁 Script executed:
Repository: rainlanguage/rain.math.float
Length of output: 1687
Tests will fail when fork RPC URLs are not configured. The env vars are set unconditionally with
|| ''fallback, causingvm.createSelectFork()calls to receive empty strings when secrets/vars are undefined. The tests attest/src/lib/deploy/LibDecimalFloatDeploy.t.sol:11andline 28will fail since Foundry requires non-empty RPC URLs.Either remove the
|| ''fallback and let tests skip gracefully, or add conditional logic in tests to skip when these env vars are empty.🤖 Prompt for AI Agents