Open
Conversation
Madoshakalaka
requested changes
Mar 25, 2026
| } | ||
|
|
||
| async fn all_keys() -> Result<Vec<String>> { | ||
| let promise = Self::raw().keys(); |
Collaborator
There was a problem hiding this comment.
Doesn't this return the names of all caches, as opposed to just gloo-cache ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya (* ^ ω ^)!
I've been tinkering with the browser and noticed that Gloo storage is missing some handy components, like cache storage. I've also been doing some wild science with Yew and Wasm: @opensass.
One thing up for debate: should cache storage be implemented under the service worker or directly in Gloo storage? For now, I think it's best to implement it in the Storage API.
Lemme know what you think!