added derives to close event#504
Merged
Madoshakalaka merged 1 commit intoranile:masterfrom Mar 23, 2026
Merged
Conversation
Collaborator
|
thanks for the PR PartialEq, Eq, and Hash are clearly justified, comparing close events and using them as map keys is reasonable. Ord/PartialOrd are questionable, there's no meaningful ordering for close events. Sorting by (code, reason, was_clean) in declaration order is arbitrary. Can you provide more background on your usage? |
Collaborator
|
I'm merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue #503