Use range in cmake_minimum#125
Merged
maxbachmann merged 2 commits intorapidfuzz:mainfrom Feb 11, 2025
Merged
Conversation
Contributor
Author
|
Is 3.24 the right max on the range? I saw it on the next lines of the file so figured it was a safe bet. |
Member
|
Shouldn't the right max be 3.31 for you to build with it? I don't see any reason why we wouldn't support it. |
Contributor
Author
|
It's not the maximum version it will build with, but the "maximum of the minimum" (not confusing at all). Basically I think it's supposed to be the maximum version it's been tested with. Hm, maybe 3.31 would make more sense on that criterion as well... |
Contributor
Author
|
Thanks @maxbachmann! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the following deprecation warning I got when building with CMake 3.31.5: