Open
Conversation
cases covered: 1. when we change zoom levels, if the scroll is already at the end of the lane, the loading animation is appearing infinitely. 2. if we want to stop the loading animation once the total number of records 3. new set of records are not getting loaded, because the scroll end logic is not working in all browsers of all screen sizes. Fixes: load the new set of records when the scroll is 10px above the scroll end until it reaches the total number of records in each lane Conditionally & optionally stop the infinite scroll fix pagination not working issue
satya-imaginea
commented
Jul 8, 2021
| const {onLaneScroll, cards, totalCardsCount} = this.props | ||
| // In some browsers and/or screen sizes a decimal rest value between 0 and 1 exists, so it should be checked on < 1 instead of < 0 | ||
| if (elemScrollPosition < 1 && onLaneScroll && !this.state.loading) { | ||
| if (elemScrollPosition < 10 && onLaneScroll && !this.state.loading && (!totalCardsCount || (totalCardsCount && totalCardsCount > cards.length))) { |
Author
There was a problem hiding this comment.
instead of hardcoding, we can make the loadNewRecords at position 10 become a configurable Board attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cases covered:
Fixes:
load the new set of records when the scroll is 10px above the scroll end until it reaches the total number of records in each lane
Conditionally & optionally stop the infinite scroll
fix pagination not working issue