Fixing the notebooks and adding a feature to add an azimuth angle that is parallel to the ellipse fit around the lake breeze front#23
Conversation
Owner
rcjackson
commented
Mar 19, 2026
rcjackson
commented
- Improved notebook documentation
- Add a feature to give an azimuth angle that is perpendicular to the lake breeze front, in addition to triggering over the center of mass.
- Add `azimuth_from_ellipse` to `adam.util`: fits a PCA ellipse to the lake breeze mask, finds the left/right major-axis tips, and returns the azimuth perpendicular to the front that points from the instrument toward the ellipse centre. - Export `azimuth_from_ellipse` from `adam.util.__init__`. - Add two unit tests in `tests/test_util.py`: horizontal-ellipse geometry check and ValueError for an empty (post-filter) mask. - Overhaul `notebooks/lake_breeze_detection_example.ipynb`: add workflow overview, numbered section headings, reference tables, fix ATMOS typos, and fix the `azimuth_point` return-value unpacking (3 → 4 values). - Remove stray debug `print` from `tests/test_inference.py`. - Bump version to 0.4.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.