add event to onChange and onAmPmChange#189
Open
Stas-Buzunko wants to merge 2 commits intoreact-component:masterfrom
Open
add event to onChange and onAmPmChange#189Stas-Buzunko wants to merge 2 commits intoreact-component:masterfrom
Stas-Buzunko wants to merge 2 commits intoreact-component:masterfrom
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/react-component/time-picker/khumntal6 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 6 6
Lines 381 381
Branches 99 99
=======================================
Hits 350 350
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
afc163
approved these changes
Feb 18, 2020
|
Please why as this not been merged and to master for release. This feature is needed |
|
Will this PR be merged to master soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when time-picker is used with react-bootstrap Modals / Popovers / Overlays and you click on time it makes Modals / Popovers / Overlays close because this event happens outside container
the only way to control this by passing event so that it can't be prevented / stopped.
Some people in issues said they need to modify event for some reasons
#173
#92
feel free to modify pr as i've done it quickly for my own needs.