ci: fold e2e tests into the tests.yml matrix instead of a separate workflow - #424
Merged
Conversation
…rkflow Both workflows repeated the same environment setup (checkout, PHP, pnpm/node, composer stub installs) to run different commands. e2e.yml only needed one PHP version and duplicated that setup across its own 3-job OS matrix. Run pnpm test:e2e as extra steps on the php-8.4 leg of the existing os x php matrix (one run per OS, same as before), cutting total CI jobs from 12 to 9 and removing the duplicated setup. Note: since the php-8.4 leg now installs every compatible PHPUnit/Pest stub version (not just v12/v4 like e2e.yml did), and .vscode-test.mjs picks the first detected stub per type, e2e now exercises PHPUnit v9 / Pest v2 instead of v12/v4. Worth revisiting if testing the newest version specifically was intentional.
Now that the merged php-8.4 CI leg installs every compatible PHPUnit/Pest stub version, picking stubs[0] selected the oldest (v9/v2) instead of the newest (v12/v4) that e2e.yml used to test. Use .at(-1) to pick the newest version actually available in the current environment, restoring the original intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e.ymlandtests.ymlrepeated the same environment setup (checkout, PHP, pnpm/node, composer stub installs) just to run different commands (pnpm test:e2evspnpm vitest --coverage).e2e.ymlonly ever exercised one PHP version (8.4, since it onlycomposer installs the v12/v4 stubs) but still ran its own 3-job OS matrix with a full duplicate setup.tests.ymlas extra steps gated to thephp == '8.4'leg of the existingos x phpmatrix (one e2e run per OS, same as before). Deletede2e.yml.Note
The
php-8.4leg installs every compatible PHPUnit/Pest stub version (not just v12/v4 likee2e.ymldid), and.vscode-test.mjspicks the first detected stub per type — so e2e now runs against PHPUnit v9 / Pest v2 instead of v12/v4. Flagging this in case testing the newest version specifically was intentional; happy to follow up with a version pin in.vscode-test.mjsif so.Test plan
php-8.4legs still run e2e correctly on all 3 OSes