Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public function refactor(Node $node): ?Class_

$ancestors = array_filter(
$classReflection->getAncestors(),
fn (ClassReflection $ancestorClassReflection): bool => $classReflection->isClass() && $ancestorClassReflection->getName() !== $classReflection->getName()
fn (ClassReflection $ancestorClassReflection): bool => $ancestorClassReflection->getName() !== $classReflection->getName()
);

$hasChanged = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,7 @@ public function refactor(Node $node): ?Node

private function shouldSkip(ClassMethod $classMethod, ClassReflection $classReflection): bool
{
// unreliable to detect trait, interface, anonymous class: doesn't make sense
if ($classReflection->isTrait()) {
return true;
}

if ($classReflection->isInterface()) {
return true;
}

// unreliable to detect anonymous class: doesn't make sense
if ($classReflection->isAnonymous()) {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,7 @@ private function shouldSkip(ClassMethod $classMethod): bool
}

$classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
if (! $classReflection instanceof ClassReflection) {
return true;
}

return ! $classReflection->isClass();
return ! $classReflection instanceof ClassReflection;
}

private function isParamUsedInSpreadArg(ClassMethod $classMethod, Param $param): bool
Expand Down
Loading