DRAFT [DeadCode] Skip RemoveReturnTagIncompatibleWithNativeTypeRector on a type alias nested in a union - #8319
Merged
TomasVotruba merged 3 commits intoAug 18, 2026
Conversation
Philosoft
marked this pull request as draft
August 7, 2026 19:29
TomasVotruba
marked this pull request as ready for review
August 10, 2026 20:33
…type alias nested in a union A @phpstan-type alias name is not resolved to the type it stands for, it becomes a NonExistingObjectType. So "@return ConfigArray|CustomConfig" over a native "array" looked like a contradiction and the tag was removed. The alias guard only matched when the whole @return type was a single IdentifierTypeNode. Look the name up in every identifier of the type node instead, which covers unions, nullables and intersections as well. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
TomasVotruba
force-pushed
the
fix/respect-union-of-aliases
branch
from
August 10, 2026 20:33
f2d468d to
d395e98
Compare
samsonasik
reviewed
Aug 13, 2026
| &$hasTypeAliasName | ||
| ): ?int { | ||
| if ($astNode instanceof IdentifierTypeNode && isset($typeAliases[$astNode->name])) { | ||
| $hasTypeAliasName = true; |
Member
There was a problem hiding this comment.
this can return stop traversal early as inner traversal:
Suggested change
| $hasTypeAliasName = true; | |
| $hasTypeAliasName = true; | |
| return \Rector\PhpDocParser\PhpDocParser\PhpDocNodeTraverser::STOP_TRAVERSAL; |
Member
There was a problem hiding this comment.
Applied in a16c2d1 — returns PhpDocNodeTraverser::STOP_TRAVERSAL once an alias name is found. Thanks!
Member
|
@Philosoft could you update the PR per my suggestion above? #8319 (review) Thank you. |
Member
|
Let's give it a go... thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A @phpstan-type alias name is not resolved to the type it stands for, it becomes a NonExistingObjectType. So "@return ConfigArray|CustomConfig" over a native "array" looked like a contradiction and the tag was removed.
The alias guard only matched when the whole @return type was a single IdentifierTypeNode. Look the name up in every identifier of the type node instead, which covers unions, nullables and intersections as well.
draft fix for rectorphp/rector#9846