Ansible code bot recommendations

.yamllint

@@ -1,11 +1,11 @@
 ---
 yaml-files:
-  - '*.yaml'
-  - '*.yml'
-  - '.yamllint'
+  - "*.yaml"
+  - "*.yml"
+  - .yamllint
 
 rules:
   truthy:
     allowed-values:
-      - 'true'
-      - 'false'
+      - "true"
+      - "false"

collections/requirements.yml

@@ -1,43 +1,43 @@
 ---
 collections:
   - name: ansible.posix
-    version: '1.5.4'
+    version: 1.5.4
   - name: ansible.utils
-    version: '5.0.0'
+    version: 5.0.0
   - name: ansible.eda
-    version: '1.4.7'
+    version: 1.4.7
   - name: ansible.netcommon
-    version: '7.0.0'
+    version: 7.0.0
   - name: ansible.controller
-    version: '4.5.7'
+    version: 4.5.7
   - name: community.crypto
-    version: '2.20.0'
+    version: 2.20.0
   - name: community.general
-    version: '8.3.0'
+    version: 8.3.0
   - name: community.dns
-    version: '3.0.1'
+    version: 3.0.1
   - name: azure.azcollection
-    version: '2.4.0'
+    version: 2.4.0
   - name: redhat.rhel_idm
-    version: '1.12.1'
+    version: 1.12.1
   - name: redhat.rhel_system_roles
-    version: '1.23.0'
+    version: 1.23.0
   - name: redhat.satellite_operations
-    version: '3.0.0'
+    version: 3.0.0
   - name: redhat.satellite
-    version: '4.0.0'
+    version: 4.0.0
   - name: infra.aap_utilities
-    version: '2.5.1'
+    version: 2.5.1
   - name: infra.controller_configuration
-    version: '2.7.1'
+    version: 2.7.1
   - name: infra.ee_utilities
-    version: '3.2.0'
+    version: 3.2.0
   - name: infra.ah_configuration
-    version: '2.0.6'
+    version: 2.0.6
   - name: infra.leapp
-    version: '1.3.1'
+    version: 1.3.1
   - name: containers.podman
-    version: '1.13.0'
+    version: 1.13.0
 
 roles:
   - name: RedHatOfficial.rhel9_cis

mkdocs.yml

@@ -25,36 +25,36 @@ markdown_extensions:
   - attr_list
   - md_in_html
   - pymdownx.emoji:
-      emoji_index: !!python/name:material.extensions.emoji.twemoji
-      emoji_generator: !!python/name:material.extensions.emoji.to_svg
+      emoji_index: !!%20python/name:material.extensions.emoji.twemoji
+      emoji_generator: !!%20python/name:material.extensions.emoji.to_svg
 nav:
   - Home:
-    - index.md
-    - where_to_start.md
+      - index.md
+      - where_to_start.md
   - Infrastructure:
-    - Identity Management: idm_architecture.md
-    - Ansible Automation Platform: aap_architecture.md
-    - Red Hat Satellite: satellite_architecture.md
+      - Identity Management: idm_architecture.md
+      - Ansible Automation Platform: aap_architecture.md
+      - Red Hat Satellite: satellite_architecture.md
   - RHEL:
-    - live_kernel.md
+      - live_kernel.md
   - Ansible:
-    - ansible_practices.md
-    - manage_credentials.md
-    - gitops_ansible.md
-    - azure_ansible_integration.md
+      - ansible_practices.md
+      - manage_credentials.md
+      - gitops_ansible.md
+      - azure_ansible_integration.md
   - Azure:
-    - network_design.md
-    - cost_estimation.md
-    - azure_rhib_integration.md
-    - azure_start_stop_function.md
+      - network_design.md
+      - cost_estimation.md
+      - azure_rhib_integration.md
+      - azure_start_stop_function.md
   - General:
-    - general_guidelines.md
-    - onboarding.md
-    - subscriptions.md
-    - git_cheat_sheet.md
-    - github_user.md
-    - sign_commits.md
-    - branch_standards.md
-    - naming_scheme.md
-    - configure_workstation_for_bastion.md
-    - slack_integration.md
+      - general_guidelines.md
+      - onboarding.md
+      - subscriptions.md
+      - git_cheat_sheet.md
+      - github_user.md
+      - sign_commits.md
+      - branch_standards.md
+      - naming_scheme.md
+      - configure_workstation_for_bastion.md
+      - slack_integration.md

playbooks/function_aap_configure.yml

@@ -6,7 +6,7 @@
   pre_tasks:
     - name: Wait for Controller to come up
       ansible.builtin.uri:
-        url: "https://{{ groups.aap_controller | first }}/api/v2/ping"
+        url: https://{{ groups.aap_controller | first }}/api/v2/ping
         status_code: 200
       register: result
       until: result.status == 200

playbooks/function_ca_create.yml

@@ -20,4 +20,4 @@
       tags: git_repo_commit
       vars:
         git_repo_commit_repository: "{{ github_inventory_repo_path }}"
-        git_repo_commit_file: { src: "{{ __path_file_encrypted }}", dest: "group_vars/all/" }
+        git_repo_commit_file: { src: "{{ __path_file_encrypted }}", dest: group_vars/all/ }

playbooks/function_enable_live_kernel.yml

@@ -14,23 +14,23 @@
 
         - name: Deploy / update related Kernel Patch for Live Kernel Patching
           ansible.builtin.package:
-            name: "kpatch-patch = {{ ansible_kernel }}"
+            name: kpatch-patch = {{ ansible_kernel }}
             state: "{{ package_state | default(omit) }}"
           register: __package_install
 
         - name: Get status of kpatch-dnf
           ansible.builtin.command:
-            cmd: "dnf kpatch status"
+            cmd: dnf kpatch status
           register: __status_dnf_kpatch
           changed_when: false
 
         - name: Enable DNF plugin for auto install live patches
           ansible.builtin.command:
-            cmd: "dnf -y kpatch auto"
+            cmd: dnf -y kpatch auto
           changed_when: true
           when: "'Kpatch update setting: manual' in __status_dnf_kpatch.stdout"
 
       rescue:
         - name: Rescue message
           ansible.builtin.debug:
-            msg: "No kernel live patch update package exist or system is not subscribed to the repository"
+            msg: No kernel live patch update package exist or system is not subscribed to the repository

playbooks/function_github_runner_create.yml

@@ -81,6 +81,6 @@
 
     - name: Create cron job to ensure Docker socket link at boot
       ansible.builtin.cron:
-        name: "Ensure Docker socket link at boot"
+        name: Ensure Docker socket link at boot
         special_time: reboot
         job: "{{ ansible_env.HOME }}/create-docker-sock-link.sh"

playbooks/function_leapp_test.yml

@@ -6,5 +6,5 @@
   tasks:
     - name: Check that you can connect (GET) to a page and it returns a status 200
       ansible.builtin.uri:
-        url: "http://{{ host }}"
+        url: http://{{ host }}
       delegate_to: "{{ groups.aap_controller[0] }}"

playbooks/function_satellite_promote_ccv.yml

@@ -1,6 +1,6 @@
 ---
 - name: RH Satellite - Promote CCV to Lifecycle
-  hosts: "satellite"
+  hosts: satellite
   gather_facts: false
 
   tasks:

playbooks/function_satellite_publish_cvs.yml

@@ -1,6 +1,6 @@
 ---
 - name: RH Satellite - Publish CVs
-  hosts: "satellite"
+  hosts: satellite
   gather_facts: false
 
   tasks:

playbooks/landscape_init.yml

@@ -1,3 +1,3 @@
 ---
-- name: "Phase 0 - Initialize Local Environment"
+- name: Phase 0 - Initialize Local Environment
   ansible.builtin.import_playbook: function_init_environment.yml

playbooks/landscape_site.yml

@@ -1,50 +1,50 @@
 ---
-- name: "Phase 1 - Create Bastion VM"
+- name: Phase 1 - Create Bastion VM
   ansible.builtin.import_playbook: type_bastion_create.yml
 
-- name: "Phase 2 - Create RootCA VM"
+- name: Phase 2 - Create RootCA VM
   ansible.builtin.import_playbook: type_rootca_create.yml
 
-- name: "Phase 3 - Create Github Runner VM"
+- name: Phase 3 - Create Github Runner VM
   ansible.builtin.import_playbook: type_github_runner_create.yml
 
-- name: "Phase 4.1 - Create IdM ipaserver"
+- name: Phase 4.1 - Create IdM ipaserver
   ansible.builtin.import_playbook: type_ipaserver_create.yml
 
-- name: "Phase 4.2 - Create IdM ipareplicas"
+- name: Phase 4.2 - Create IdM ipareplicas
   ansible.builtin.import_playbook: type_ipareplicas_create.yml
 
-- name: "Phase 4.3 - Configure IdM"
+- name: Phase 4.3 - Configure IdM
   ansible.builtin.import_playbook: type_ipa_config.yml
 
-- name: "Phase 5.1 - Install Satellite"
+- name: Phase 5.1 - Install Satellite
   ansible.builtin.import_playbook: type_satellite_install.yml
 
-- name: "Phase Intermediary -  Deploy Azure Resources for Workload Intra"
+- name: Phase Intermediary -  Deploy Azure Resources for Workload Intra
   ansible.builtin.import_playbook: type_workload_intra_resources_create.yml
 
 # RHIS project currently not deploying workload resources in DMZ.
 # However, it has to capability to do that if intended to do
 # - name: "Phase Intermediary -  Deploy Azure Resources for Workload Intra"
 #   ansible.builtin.import_playbook: type_workload_dmz_resources_create.yml
 
-- name: "Phase 5.2 - Configure Satellite"
+- name: Phase 5.2 - Configure Satellite
   ansible.builtin.import_playbook: type_satellite_configure.yml
 
-- name: "Phase 6.1 - Create AAP VMs"
+- name: Phase 6.1 - Create AAP VMs
   ansible.builtin.import_playbook: type_aap_create_infrastructure.yml
 
-- name: "Phase Intermediary -  Register Management VMs to IdM and Satellite"
+- name: Phase Intermediary -  Register Management VMs to IdM and Satellite
   ansible.builtin.import_playbook: type_idm_satellite_register.yml
 
-- name: "Phase 6.2 - Install AAP"
+- name: Phase 6.2 - Install AAP
   ansible.builtin.import_playbook: type_aap_install.yml
 
-- name: "Phase 6.2 - Configure AAP"
+- name: Phase 6.2 - Configure AAP
   ansible.builtin.import_playbook: type_aap_configure.yml
 
-- name: "Phase 7 - Create Reverse Proxy"
+- name: Phase 7 - Create Reverse Proxy
   ansible.builtin.import_playbook: type_reverse_proxy_create.yml
 
-- name: "Phase X - Enforce CIS on all hosts"
+- name: Phase X - Enforce CIS on all hosts
   ansible.builtin.import_playbook: type_cis_enforce.yml

playbooks/toolbox_satellite_hostgroup_change.yml

@@ -3,27 +3,26 @@
   hosts: "{{ host | default('localhost') }}"
   gather_facts: true
   tasks:
-
     - name: Get host's satellite information
-      redhat.satellite.host_info:
+      register: __out
+      theforeman.foreman.host_info:
         username: "{{ hostvars[groups['satellite'][0]]['satellite_username'] }}"
         password: "{{ hostvars[groups['satellite'][0]]['satellite_password'] }}"
         server_url: "{{ hostvars[groups['satellite'][0]]['satellite_server_url'] }}"
         name: "{{ host }}"
-      register: __out
 
     - name: Set new host group if it's a parent host group
       ansible.builtin.set_fact:
-        satellite_hostgroup_post: "hg_rhel{{ ansible_distribution_version }}"
-      when: ((__out.host.hostgroup_title.split('/') | map('trim'))[:-1] | join('/')) == ""
+        satellite_hostgroup_post: hg_rhel{{ ansible_distribution_version }}
+      when: ((__out.host.hostgroup_title.split('/') | map('trim'))[:-1] | join('/')) | length == 0
 
     - name: Set new host group if it's not a parent host group
       ansible.builtin.set_fact:
         satellite_hostgroup_post: "{{ (__out.host.hostgroup_title.split('/') | map('trim'))[:-1] | join('/') }}/hg_rhel{{ ansible_distribution_version }}"
-      when: ((__out.host.hostgroup_title.split('/') | map('trim'))[:-1] | join('/')) != ""
+      when: ((__out.host.hostgroup_title.split('/') | map('trim'))[:-1] | join('/')) | length > 0
 
     - name: Update satellite hostgroup
-      redhat.satellite.host:
+      awx.awx.host:
         username: "{{ hostvars[groups['satellite'][0]]['satellite_username'] }}"
         password: "{{ hostvars[groups['satellite'][0]]['satellite_password'] }}"
         server_url: "{{ hostvars[groups['satellite'][0]]['satellite_server_url'] }}"

playbooks/type_aap_configure.yml

@@ -1,5 +1,5 @@
 ---
-- name: "AAP Configuration"
+- name: AAP Configuration
   ansible.builtin.import_playbook: function_aap_configure.yml
   vars:
     host: aap_controller

playbooks/type_aap_create_infrastructure.yml

@@ -1,5 +1,5 @@
 ---
-- name: "AAP VMs - Create"
+- name: AAP VMs - Create
   ansible.builtin.import_playbook: function_azure_vm_create.yml
   when:
     - bootstrap_target is defined
@@ -9,21 +9,21 @@
   tags:
     - aap_vm_create
 
-- name: "AAP VM - Check if Reachable"
+- name: AAP VM - Check if Reachable
   ansible.builtin.import_playbook: toolbox_vm_wait_response.yml
   vars:
     host: aap_intra
   tags:
     - aap_vm_create
 
-- name: "AAP VM - Post Configure"
+- name: AAP VM - Post Configure
   ansible.builtin.import_playbook: function_vm_post_configure.yml
   vars:
     host: aap_intra
   tags:
     - aap_vm_post_conf
 
-- name: "AAP VM - Create Managed Disk"
+- name: AAP VM - Create Managed Disk
   ansible.builtin.import_playbook: function_azure_managed_disk_create.yml
   when:
     - bootstrap_target is defined
@@ -33,7 +33,7 @@
   tags:
     - aap_vm_post_conf
 
-- name: "AAP VM - Run RHEL Storage"
+- name: AAP VM - Run RHEL Storage
   ansible.builtin.import_playbook: function_rhel_managed_disk_configure.yml
   vars:
     host: aap_intra

playbooks/type_aap_install.yml

@@ -1,12 +1,12 @@
 ---
-- name: "AAP - Generate Host Certificates"
+- name: AAP - Generate Host Certificates
   ansible.builtin.import_playbook: function_idm_generate_certs.yml
   vars:
     host: aap_intra
   tags:
     - aap_cert_generate
 
-- name: "AAP - Install"
+- name: AAP - Install
   ansible.builtin.import_playbook: function_aap_install.yml
   vars:
     host: bastion