Skip to content

Add missing commands to UnifiedJedis#4450

Open
uglide wants to merge 3 commits into
masterfrom
im/add-missing-commands
Open

Add missing commands to UnifiedJedis#4450
uglide wants to merge 3 commits into
masterfrom
im/add-missing-commands

Conversation

@uglide

@uglide uglide commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Add implementation for the:

  • CLIENT commands
  • CONFIG commands
  • Various server commands like: dbsize, time, etc

Note

Medium Risk
Expands UnifiedJedis API surface and introduces cluster broadcast behavior for server/config commands, which can have correctness differences across nodes (some cases already require disabling/expecting failures in cluster tests). Mostly additive changes but touches core command plumbing and public interfaces.

Overview
Adds missing Redis command coverage to UnifiedJedis, including common server commands (ping w/ message, binary echo, flushAll/flushDB w/ FlushMode, lolwut, time, dbSize), plus full CONFIG and CLIENT command support.

Extends CommandObjects with the new command builders and wires UnifiedJedis to execute vs broadcast the new operations as appropriate; adds integration tests for client/config behavior in both standalone and cluster modes (with a few cluster-incompatible cases explicitly disabled/expected to throw).

Refactors the command API by splitting ServerCommands and DatabaseCommands into smaller sub-interfaces (e.g., CommonServerCommands, AuthCommands, ShutdownCommands, NodeDatabaseCommands, etc.) while keeping ServerCommands/DatabaseCommands as composite interfaces for backward compatibility.

Written by Cursor Bugbot for commit a526c86. This will update automatically on new commits. Configure here.

@jit-ci

jit-ci Bot commented Feb 26, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@github-actions

github-actions Bot commented Feb 26, 2026

Copy link
Copy Markdown

Test Results

   305 files  +  4     305 suites  +4   11m 56s ⏱️ +11s
11 076 tests +168  10 858 ✅ +6  218 💤 +162  0 ❌ ±0 
 5 687 runs  + 56   5 619 ✅  - 3   68 💤 + 59  0 ❌ ±0 

Results for commit a526c86. ± Comparison against base commit f669f98.

This pull request skips 159 tests.
redis.clients.jedis.commands.jedis.ClusterHotkeysCommandsTest ‑ hotkeysGetNotSupportedInCluster
redis.clients.jedis.commands.jedis.ClusterHotkeysCommandsTest ‑ hotkeysResetNotSupportedInCluster
redis.clients.jedis.commands.jedis.ClusterHotkeysCommandsTest ‑ hotkeysStartNotSupportedInCluster
redis.clients.jedis.commands.jedis.ClusterHotkeysCommandsTest ‑ hotkeysStopNotSupportedInCluster
redis.clients.jedis.commands.jedis.ClusterHotkeysCommandsTest ‑ hotkeysWithSlotsOnSingleClusterNode
redis.clients.jedis.commands.jedis.HotkeysCommandsTest[1] ‑ hotkeysBothMetrics
redis.clients.jedis.commands.jedis.HotkeysCommandsTest[1] ‑ hotkeysDurationOption
redis.clients.jedis.commands.jedis.HotkeysCommandsTest[1] ‑ hotkeysGetBeforeStart
redis.clients.jedis.commands.jedis.HotkeysCommandsTest[1] ‑ hotkeysLifecycle
redis.clients.jedis.commands.jedis.HotkeysCommandsTest[1] ‑ hotkeysResponseFields
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant