Skip to content

Conversation

@emeraldDevUA
Copy link
Member

@emeraldDevUA emeraldDevUA commented Dec 1, 2025

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)

What was changed?

https://github.com/reductstore/ros-ext/pull/66

Related issues

No known issues

Does this PR introduce a breaking change?

No

Other information:

@emeraldDevUA emeraldDevUA requested a review from atimin December 1, 2025 20:34
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-259.westeurope.5.azurestaticapps.net

Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the 'Query Format' section. Add the 'as_label' field to the JSON schema and the table in the 'Data Extraction' subsection.

We don't document our changes for the website, but we put the link to your PR in the ros-ext project so that the PR is connected with the code.

To format the text, run: yarn fmt

@atimin
Copy link
Member

atimin commented Dec 2, 2025

@emeraldDevUA please change the titile., It's too generic. Something like Document as_lable parameter in Ros Ext.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-259.westeurope.5.azurestaticapps.net

@emeraldDevUA emeraldDevUA requested a review from atimin December 2, 2025 16:14
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-259.westeurope.5.azurestaticapps.net

@atimin atimin changed the title Ros update Document as_lable parameter in Ros Ext Dec 2, 2025
Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more turn is necessary.

"topic": "string", # ROS topic name to extract from
"encode": "object", # e.g., {"data":"jpeg"} for JPEG encoding
"as_label": "object" # e.g., {"label_name": "path_to_json"}
},"when": "object" # e.g., {"@label_name" : {"$eq": "specified_value"}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when is not the part of the extension query.

- `schema`: `sensor_msgs/Image`
- `encoding`: `cdr`

### Using as_label parameter in ROS-EXT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using extracted data for filtering


This example demonstrates how to use the ROS extension to apply filters to the JSON output of ReductStore.

```json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make a python script. The scripts are run in the CI/CD pipeline automatically and we make sure it works. See how other examples works.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-259.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-259.westeurope.5.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants