-
Notifications
You must be signed in to change notification settings - Fork 3
Document as_lable parameter in Ros Ext #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-259.westeurope.5.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the 'Query Format' section. Add the 'as_label' field to the JSON schema and the table in the 'Data Extraction' subsection.
We don't document our changes for the website, but we put the link to your PR in the ros-ext project so that the PR is connected with the code.
To format the text, run: yarn fmt
|
@emeraldDevUA please change the titile., It's too generic. Something like Document as_lable parameter in Ros Ext. |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-259.westeurope.5.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-259.westeurope.5.azurestaticapps.net |
atimin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more turn is necessary.
docs/extensions/official/ros-ext.mdx
Outdated
| "topic": "string", # ROS topic name to extract from | ||
| "encode": "object", # e.g., {"data":"jpeg"} for JPEG encoding | ||
| "as_label": "object" # e.g., {"label_name": "path_to_json"} | ||
| },"when": "object" # e.g., {"@label_name" : {"$eq": "specified_value"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when is not the part of the extension query.
docs/extensions/official/ros-ext.mdx
Outdated
| - `schema`: `sensor_msgs/Image` | ||
| - `encoding`: `cdr` | ||
|
|
||
| ### Using as_label parameter in ROS-EXT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using extracted data for filtering
docs/extensions/official/ros-ext.mdx
Outdated
|
|
||
| This example demonstrates how to use the ROS extension to apply filters to the JSON output of ReductStore. | ||
|
|
||
| ```json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make a python script. The scripts are run in the CI/CD pipeline automatically and we make sure it works. See how other examples works.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-259.westeurope.5.azurestaticapps.net |
# Conflicts: # docs/examples/py/src/ext_ros_mcap_extract_filtered.py
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-259.westeurope.5.azurestaticapps.net |
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
What was changed?
https://github.com/reductstore/ros-ext/pull/66
Related issues
No known issues
Does this PR introduce a breaking change?
No
Other information: