ci(agents): wire agent-001-registry-reviewer into the typecheck matrix#96
Merged
glandua merged 1 commit intoApr 25, 2026
Merged
Conversation
The AGENT-001 Registry Reviewer standalone TypeScript implementation has been in the repo since PR regen-network#64 but was never wired into the CI `Agents` job. Only `agents/` (the ElizaOS character pack) and `agent-002-governance-analyst/` run `npx tsc --noEmit` on every PR. `agent-001-registry-reviewer/` has its own `package.json`, `tsconfig.json`, and a full workflow implementation (reviewer, ooda, 3 workflows, ledger client, store, types). It compiles cleanly on Node 22 locally — this PR adds it to the CI matrix so regressions are caught on every PR. After PRs regen-network#80 and regen-network#81 (which added agent-003 and agent-004 to CI), this PR closes the gap for the only remaining unwired standalone agent: agent-001. The full CI Agents job now typechecks four standalone agent processes: agents/ (ElizaOS character pack) agent-001-registry-reviewer/ (this PR) agent-002-governance-analyst/ (already wired) agent-003-market-monitor/ (added in PR regen-network#80) agent-004-validator-monitor/ (added in PR regen-network#81) ## Validation $ cd agent-001-registry-reviewer && npm ci && npx tsc --noEmit (exit 0) Same commands as the CI step. - Lands in: `.github/workflows/ci.yml` - Changes: add agent-001-registry-reviewer npm ci + typecheck steps - Validate: `cd agent-001-registry-reviewer && npm ci && npx tsc --noEmit`
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The AGENT-001 Registry Reviewer standalone TypeScript implementation has been in the repo since #64 but was never wired into the CI `Agents` job. Only `agents/` and `agent-002-governance-analyst/` run `npx tsc --noEmit` on every PR. This PR closes that gap.
Before and after
After PRs #80 (agent-003) and #81 (agent-004) which added the two new standalone agents to the CI matrix, the only remaining unwired agent was `agent-001-registry-reviewer`. This PR fills the gap.
After this PR, the CI `Agents` job typechecks 5 standalone agent processes:
Why this matters
`agent-001-registry-reviewer` is a full standalone Node.js process with its own OODA loop, reviewer, three workflows (class screening, project validation, batch review), ledger client, and SQLite store. It compiles cleanly on Node 22, but without CI coverage any regression (dependency drift, TypeScript upgrade, API shift in the Cosmos LCD types) would land silently until someone runs the typecheck locally. That's not a good place to leave working code.
Test plan