fix: correct XSLT classpath/factory ordering and restore test target #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix XSLT factory/classpath element ordering in build.xml and build.xsl - Restore missing test target (was ant-test until f31c15d) to match README - Prevents "factory doesn't support nested classpath element" errors Signed-off-by: UncleSp1d3r <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes build configuration issues by restoring a missing test target and standardizing the placement and syntax of Saxon TransformerFactory elements across build files.
- Restored the
testtarget inbuild.xmlto align with README documentation - Standardized
factoryelement placement to followclasspathelements consistently - Fixed improper
factoryelement syntax inbuild.xslby using self-closing tags
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build.xml | Restored test target and moved factory elements after classpath elements in modbuild and jing-doc targets |
| build.xsl | Fixed factory element syntax by replacing improperly closed tag with self-closing tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to the build configuration by restoring a missing test target and standardizing the placement of the
factoryelement for Saxon TransformerFactory. These changes enhance consistency and ensure alignment with documentation.Build configuration updates:
Restored test target in
build.xml: Added atesttarget to the build file, which was previously removed, to align with the README documentation. This target runs the complete test suite defined inmodbuild.xml.Standardized
factoryelement placement inbuild.xml: Moved thefactoryelement (net.sf.saxon.TransformerFactoryImpl) to follow theclasspathelement in multiple locations for consistency. This change affects themodbuildandjing-doctargets. [1] [2]Corrected
factoryelement syntax inbuild.xsl: Replaced an improperly closedfactoryelement with a self-closing tag fornet.sf.saxon.TransformerFactoryImplin the XSL transformation configuration.