fix: fail fast on empty api key and profile inputs instead of falling back#346
Draft
bukinoshita wants to merge 1 commit into
Draft
fix: fail fast on empty api key and profile inputs instead of falling back#346bukinoshita wants to merge 1 commit into
bukinoshita wants to merge 1 commit into
Conversation
… back Empty --api-key/--profile flags and RESEND_API_KEY/RESEND_PROFILE env vars were treated as missing by truthiness checks, so commands silently fell back to other credentials and could target the wrong account. Explicitly provided empty values now raise a clear validation error at the point they would be consulted, and logout with an empty --profile no longer removes all profiles. Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Reject empty
--api-key,--profile,RESEND_API_KEY, andRESEND_PROFILEto prevent silent fallback to other credentials and accidental account usage.logout --profile ""now errors instead of removing all profiles. Addresses BU-2298.requireNonEmptyto error on empty inputs and ignore undefined.resolveProfileName,resolveApiKey, andresolveAuthentication;client/whoaminow use!== undefined/??instead of truthiness.logout: empty--profileis an error; only logs out all when no profile is provided.auth_error/profile_not_found; normal precedence and behavior unchanged.Written for commit 77ae49c. Summary will update on new commits.