feat: add message_id to Email type#232
Conversation
Add message_id to the Email type for GET /emails/:id and list responses. Introduce typed webhook event payloads (WebhookEventPayload) matching the Node.js SDK, including message_id on all outbound email webhook events. Update Webhooks.verify to return the parsed and verified event payload. Co-authored-by: cpenned <cpenned@users.noreply.github.com>
Co-authored-by: cpenned <cpenned@users.noreply.github.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: This PR modifies the public API by changing the return type of Webhooks.verify() from None to a typed payload and adding message_id to the Email model. Such changes risk breaking existing code and require human review for backward compatibility.
Re-trigger cubic
Remove webhook event payload types and Webhooks.verify return type change. Received email types already include message_id. Co-authored-by: cpenned <cpenned@users.noreply.github.com>
cursor
Bot
changed the title
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Auto-approved: Adds a new message_id field to the Email model and updates tests. Low-risk additive change with no logic, config, or infrastructure impact.
Re-trigger cubic
Co-authored-by: cpenned <cpenned@users.noreply.github.com>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: Adds a new response field to the Email type to match the Resend API. No logic changes, only model and test updates.
Re-trigger cubic
hermesresend
left a comment
hermesresend
left a comment
There was a problem hiding this comment.
LGTM — typed on _EmailDefaultAttrs so both get and list benefit, docstring updated, tests cover both paths.
3 participants
Summary
Adds
message_idto theEmailtype forGET /emails/:idand list responses, matching the updated Resend API and Node.js SDK.Changes
resend.Emailnow includesmessage_id: strNote:
message_idwas already typed on inbound/received email types (ReceivedEmail,ListReceivedEmail) used by receiving webhooks.Summary by cubic
Adds
message_idto theEmailtype soGET /emails/:idand list responses include the RFC Message-ID. This makes it easy to link SDK results to SMTP headers and external systems.Written for commit cb4d939. Summary will update on new commits.