fix: replace mock tipping txHash with real on-chain transfer - #1264
Open
captainjoel2019-bit wants to merge 3 commits into
Open
Conversation
|
@captainjoel2019-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Well done on the job done so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces the mock tipping notarization with real on-chain settlement. Tips are now sent as actual blockchain transactions using
serviceAccount.sendTransaction(), and the notarization record stores the real transaction hash, the service account sender address, and the configured network chain ID. Failed on-chain transactions return HTTP 502 with retry advice instead of a fake success hash.Related Issue
Changes
🔗 Real On-Chain Tip Settlement
[MODIFY]
src/app/api/tipping/route.tsrandomBytes(16).toString('hex')mock txHash with the actual transaction receipt hash fromsendTransaction().senderAddressviagetServiceAddress()andchainIdfrom the configured network.[MODIFY]
src/services/serviceAccount.tssendTransaction()broadcasts a real on-chain transfer and returns the transaction receipt.[MODIFY]
.env.exampleVerification Results
sendTransaction()is stored and viewable on-chainsenderAddressandchainIdreflect real network valuesCloses #767