Skip to content

fix: merge overlapping GestureHandler event handlers - #1265

Open
Mormentz wants to merge 1 commit into
rinafcode:mainfrom
Mormentz:fix/1044-merge-gesture-handler-props
Open

fix: merge overlapping GestureHandler event handlers#1265
Mormentz wants to merge 1 commit into
rinafcode:mainfrom
Mormentz:fix/1044-merge-gesture-handler-props

Conversation

@Mormentz

Copy link
Copy Markdown

Summary

  • GestureHandler no longer lets consumer onTouch* / pointer props replace the gesture library handlers.
  • Overlapping event handlers are composed (gesture first, then consumer) so swipe, pinch, and tap still fire.
  • Adds Vitest coverage for baseline gestures, overlapping consumer handlers (including preventDefault), and non-event props.

Test plan

  • pnpm exec vitest run src/components/mobile/__tests__/GestureHandler.test.tsx
  • Confirm swipe/pinch still work when a parent also passes onTouchStart / onTouchMove / onTouchEnd

closes #1044

Consumer touch handlers no longer replace the gesture library's handlers, so swipe and pinch detection keep working.
@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@Mormentz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent consumer props from overriding gesture handlers in GestureHandler

1 participant