feat: distinguish CORS failures from generic network errors (#1163) - #1287
Open
abdulqudus-dev wants to merge 1 commit into
Open
feat: distinguish CORS failures from generic network errors (#1163)#1287abdulqudus-dev wants to merge 1 commit into
abdulqudus-dev wants to merge 1 commit into
Conversation
…e#1163) - Add CORS_BLOCKED to ErrorType enum in errorUtils.ts - Add isCorsError() utility: detects opaque CORS TypeErrors by message pattern (Failed to fetch, NetworkError, cross-origin, CORS, Load failed) with no attached HTTP status code - Wire isCorsError() into classifyError() before the NETWORK branch; CORS errors are non-retryable (server config must change, not the client) - Update loggingErrorInterceptor (apiInterceptors.ts) to log CORS blocks at a distinct message with errorType: CORS_BLOCKED in context - Update ErrorReportingService (errorReporting.ts): add corsBlocked breadcrumb, set corsBlocked flag in errorData, expose corsBlockedCount in getAnalyticsSummary() - Add 30 unit tests in cors-detection.test.ts covering isCorsError(), classifyError() CORS path, interceptor branching, and service tagging - Update pre-existing errorUtils.test.ts assertions to match new behaviour Closes rinafcode#1163
|
@abdulqudus-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Well done on the job done so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1163
Closes #1163
Description
Brief description of changes
Related Issue
Closes #
Type of Change
Checklist