fix(i18n): persist selected locale to localStorage and restore on init - #1299
Merged
RUKAYAT-CODER merged 1 commit intoAug 30, 2026
Merged
Conversation
|
@Abdulrasaq1515 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Persist the selected language to localStorage via a shared storage key constant and restore it on provider mount. Adds validation against supported languages so corrupted or invalid stored values fall back to the default locale. Wraps localStorage writes in try-catch for resilience in private browsing modes. Also reuses isRTLUtil for html dir consistency. Added comprehensive unit tests covering persistence, restoration, validation, re-mount (reload simulation), document/cookie updates, and fallback behaviour outside the provider. closes rinafcode#1294
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist the selected language to localStorage via a shared storage key constant and restore it on provider mount. Adds validation against supported languages so corrupted or invalid stored values fall back to the default locale. Wraps localStorage writes in try-catch for resilience in private browsing modes. Also reuses isRTLUtil for html dir consistency.
Added comprehensive unit tests covering persistence, restoration, validation, re-mount (reload simulation), document/cookie updates, and fallback behaviour outside the provider.
closes #1294
Description
Brief description of changes
Related Issue
Closes #
Type of Change
Checklist