Fix SQLite timestamp millisecond formatting to always include 3 digits - #1349
Merged
Conversation
Use a .000 Go time layout so SQLite timestamps always contain exactly
three fractional digits. This matches `datetime('now', 'subsec')` and
prevents equal instants from being represented differently as .1 and
.100.
In Go, time layouts work like this:
- .999 omits trailing zeros, producing values like .1
- .000 always emits three digits, producing .100
This was always a preexisting problem, but Codex happened to catch it
while implementing SQLite support in River Pro, and we may as well fix
it here too.
brandur
force-pushed
the
brandur-always-three-trailing-digits
branch
from
August 12, 2026 21:53
bf76f18 to
fdaca33
Compare
bgentry
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a .000 Go time layout so SQLite timestamps always contain exactly
three fractional digits. This matches
datetime('now', 'subsec')andprevents equal instants from being represented differently as .1 and
.100.
In Go, time layouts work like this:
This was always a preexisting problem, but Codex happened to catch it
while implementing SQLite support in River Pro, and we may as well fix
it here too.