Permissions error opening a log file is swallowed because of an error#324
Open
mkoryak wants to merge 1 commit intorlidwka:masterfrom
Open
Permissions error opening a log file is swallowed because of an error#324mkoryak wants to merge 1 commit intorlidwka:masterfrom
mkoryak wants to merge 1 commit intorlidwka:masterfrom
Conversation
Dont emit on Logger constructor, because it doesnt have that method Causes an error of 'undefined is not a function' in the log instead of the actual error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dont emit on Logger constructor, because it doesnt have that method
Causes an error of 'undefined is not a function' in the log instead of the actual error (i also have a console logger, which is where i saw the error)