Skip to content

Update RevealBase.js#70

Open
andrewlsimplisafe wants to merge 1 commit into
rnosov:masterfrom
andrewlsimplisafe:master
Open

Update RevealBase.js#70
andrewlsimplisafe wants to merge 1 commit into
rnosov:masterfrom
andrewlsimplisafe:master

Conversation

@andrewlsimplisafe
Copy link
Copy Markdown

Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps for compatibility with React 17

Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps for compatibility with React 17
@apepper
Copy link
Copy Markdown

apepper commented Oct 24, 2019

Fixes #66.

@acato-dev
Copy link
Copy Markdown

@rnosov Is it possible for you to find some time to approve and merge this update? Fixes numerous warnings due to spec changes in the react base.

@andrewlsimplisafe
Copy link
Copy Markdown
Author

The maintainer of this repo is not actively maintaining this repository. I would suggest forking this repo, fixing and then uploading to a private package repo until the maintainer is able to update/rewrite. See this issue #69

@apepper
Copy link
Copy Markdown

apepper commented Jan 21, 2020

@andrewlsimplisafe : There is a second componentWillReceiveProps in the code base. See

componentWillReceiveProps({ query }) {
.

@sauravhiremath
Copy link
Copy Markdown

sauravhiremath commented Jul 25, 2020

Hey, @andrewlsimplisafe are you still working on this?

@MichaelDeBoey
Copy link
Copy Markdown

Ping @rnosov

@ravichopra0107
Copy link
Copy Markdown

ping @noelzubin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants