Fix cross-compilation with openssl backend#2396
Open
G10h4ck wants to merge 1 commit into
Open
Conversation
FindOpenSSLFeatures.cmake uses execute_process() to run findopensslfeatures during configure, but execute_process() does not respect CMAKE_CROSSCOMPILING_EMULATOR (unlike try_run()). This causes configuration to fail when cross-compiling for Android, ARM, etc. because the target binary cannot execute on the host. Prepend CMAKE_CROSSCOMPILING_EMULATOR to the FOF command if set, so the feature detection binary is run via the configured emulator (e.g. qemu-user) when cross-compiling. Link findopensslfeatures statically when CMAKE_CROSSCOMPILING_EMULATOR is enabled to avoid linker not found errors when emulator attempt to run it
Author
|
ping @ni4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FindOpenSSLFeatures.cmake uses execute_process() to run findopensslfeatures during configure, but execute_process() does not respect CMAKE_CROSSCOMPILING_EMULATOR (unlike try_run()). This causes configuration to fail when cross-compiling for Android, ARM, etc. because the target binary cannot execute on the host.
Prepend CMAKE_CROSSCOMPILING_EMULATOR to the FOF command if set, so the feature detection binary is run via the configured emulator (e.g. qemu-user) when cross-compiling.
Link findopensslfeatures statically when CMAKE_CROSSCOMPILING_EMULATOR is enabled to avoid linker not found errors when emulator attempt to run it