Open
Conversation
…11 cannot complie Cartography pod anymore. Renaming constrain functions to cg_constrain seems to fix the problem
Collaborator
|
This is a pretty drastic API change - are there any other ideas to make this work? |
Author
|
@orta I guess you can leave it as is and just expect everyone to use namespaces. |
Collaborator
|
I think this is probably better, yeah 👍 Any chance you can update docs and then this is good to go? |
|
Any update on this? Can we push this up if everything looks fine? |
Collaborator
|
This changes the API in a way that makes all the README's examples not work - happy to have you fix that in a PR with these changes also? |
Merged
Collaborator
|
Happy to have someone re-implement the PR with the feedback rather than wait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
constrainfunction is defined inCommonUISDKlooks like XCode11 cannot compile Cartography pod anymore.Renaming
constrainfunctions tocg_constrainseems to fix the problemcloses: #313