feat(connect): add Qoder CLI CN adapter#920
Conversation
|
Someone is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughAdds support for Qoder CLI CN by introducing a new ChangesQoder CLI CN Agent Integration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/cli/connect/index.ts (1)
23-42:⚠️ Potential issue | 🟠 Major | ⚡ Quick winKeep the OpenCode adapter/docs in sync.
Removing
opencodefromADAPTERSmakesagentmemory connect opencodefail and removes it from onboarding, butINSTALL_FOR_AGENTS.mdstill advertises it as a supported target. Either restore the adapter entry or drop OpenCode from the runbook in the same change. Affected files:src/cli/connect/index.ts,INSTALL_FOR_AGENTS.md.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/cli/connect/index.ts` around lines 23 - 42, ADAPTERS no longer contains the opencode adapter which breaks "agentmemory connect opencode" and leaves docs out of sync; either re-add the opencode adapter entry to the ADAPTERS array (use the exact exported adapter identifier name opencode so the CLI can resolve it) in the same module where ADAPTERS is defined, or if you intentionally removed support, remove or update the OpenCode reference in INSTALL_FOR_AGENTS.md so the runbook matches the codebase. Ensure the adapter identifier you add matches the adapter export name used elsewhere (opencode) and update tests or onboarding lists that reference OpenCode.
🧹 Nitpick comments (1)
src/cli/connect/qoder-clicn.ts (1)
5-8: 💤 Low valueRemove the redundant WHAT-comment.
The adapter name, config paths, and
protocolNotealready communicate this context. As per coding guidelines, "In TypeScript source code, avoid code comments explaining WHAT — use clear naming instead."♻️ Proposed cleanup
-import { createJsonMcpAdapter } from "./json-mcp-adapter.js"; - -// Qoder CLI CN (qoderclicn) is a Qwen-derived coding-agent CLI whose -// user config lives at ~/.qoder-cn/settings.json. Its mcpServers schema -// matches the standard JSON shape, so the shared adapter handles the -// wiring. Hooks are configured separately — see QODER-COMPAT.md. +import { createJsonMcpAdapter } from "./json-mcp-adapter.js"; + export const adapter = createJsonMcpAdapter({🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/cli/connect/qoder-clicn.ts` around lines 5 - 8, Remove the redundant WHAT-style header comment block that begins with "Qoder CLI CN (qoderclicn)..." — the adapter name, config paths and existing protocolNote already convey this context; simply delete that comment lines from the top of src/cli/connect/qoder-clicn.ts and leave any remaining file-level metadata (like protocolNote or TODOs) intact so naming and config live in code rather than explained in a WHAT comment.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/cli/connect/index.ts`:
- Around line 23-42: ADAPTERS no longer contains the opencode adapter which
breaks "agentmemory connect opencode" and leaves docs out of sync; either re-add
the opencode adapter entry to the ADAPTERS array (use the exact exported adapter
identifier name opencode so the CLI can resolve it) in the same module where
ADAPTERS is defined, or if you intentionally removed support, remove or update
the OpenCode reference in INSTALL_FOR_AGENTS.md so the runbook matches the
codebase. Ensure the adapter identifier you add matches the adapter export name
used elsewhere (opencode) and update tests or onboarding lists that reference
OpenCode.
---
Nitpick comments:
In `@src/cli/connect/qoder-clicn.ts`:
- Around line 5-8: Remove the redundant WHAT-style header comment block that
begins with "Qoder CLI CN (qoderclicn)..." — the adapter name, config paths and
existing protocolNote already convey this context; simply delete that comment
lines from the top of src/cli/connect/qoder-clicn.ts and leave any remaining
file-level metadata (like protocolNote or TODOs) intact so naming and config
live in code rather than explained in a WHAT comment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a4472b50-61bf-4a42-9dd6-708e0d48e592
📒 Files selected for processing (5)
INSTALL_FOR_AGENTS.mdQODER-COMPAT.mdREADME.mdsrc/cli/connect/index.tssrc/cli/connect/qoder-clicn.ts
1 participant
feat(connect): 添加对 Qoder CLI CN 的支持
添加了 Qoder CLI CN (Qwen 衍生版) 的适配器支持，包括：