This repository was archived by the owner on Aug 21, 2019. It is now read-only.
Open
Conversation
This is required due to [gitlab-pages issue rolodato#9](https://gitlab.com/gitlab-org/gitlab-pages/issues/9)
Changes the path of /.well-known/acme-challange/{key} to /letencrypt.html when --jekyll is used
Resolves 2 issues:
1. By default, Jekyll does not build any files or directories that start
with a '.'. This causes the default path of starting with .well-known to not work when --jekyll flag is used.
2. Even if the --path option is used to point the {key} file to a
non-hidden directory, jekyll gets confused with the lack of a .html extension and doesn't render it properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple issues with the --jekyll flag.
/letsencrypt.html. This helps because:a. Jekyll doesn't by default render any pages in hidden directories (e.g. the default `/.well-known/ dir)
b. Jekyll gets confused if the target file doesn't have an extension. By adding a .html extension on the filePath it can properly serve it.