Open
Conversation
cling is currently tearing down the text input before the Interpreter is destroyed. Leading to problems with pipes and file handles being close in the text input layer.
vgvassilev
reviewed
Jul 13, 2017
lib/Utils/PlatformWin.cpp
Outdated
| assert(getImageBaseMap().find(ImgBase) != getImageBaseMap().end()); | ||
|
|
||
| // Remove the ImageBase from lookup | ||
| // There is a chance that DeRegisterEHFrames will without a prior call to |
Member
There was a problem hiding this comment.
I do not understand this comment.
…tor. DeRegisterEHFrames can be called without a a prior call to RegisterEHFrames. This can easily be detected so just do nothing when that occurs.
bellenot
reviewed
Jul 13, 2017
Member
bellenot
left a comment
bellenot
left a comment
There was a problem hiding this comment.
As far as Windows is concerned, since I don't see any difference on my desktop machine, I would say it is fine with me...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UserInterface was being destroyed to early, possibly upsetting the text-input layer on Windows.
Remove an assert for Windows exception handling that was triggering too late in shutdown to be seen and hand condition at runtime.