Fix embedding: NoRuntime atexit guard + redirectable cling::outs()#564
Open
0xeb wants to merge 1 commit intoroot-project:masterfrom
Open
Fix embedding: NoRuntime atexit guard + redirectable cling::outs()#5640xeb wants to merge 1 commit intoroot-project:masterfrom
0xeb wants to merge 1 commit intoroot-project:masterfrom
Conversation
Two fixes for embedding cling in other applications: 1. Guard atexit interception with NoRuntime check: PCH files generated with -noruntime included atexit declarations, causing redefinition errors when consumer interpreters loaded the PCH. The guard matches the existing pattern used for gCling/RuntimeUniverse preamble. 2. Make cling::outs() redirectable: adds setOuts(raw_ostream*) API so embedders can capture or redirect cling's output stream. Pass nullptr to restore the default (std::cout wrapper).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for embedding cling in other applications:
Guard atexit interception with
NoRuntimecheck: PCH files generated with-noruntimeincluded atexit declarations, causing redefinition errors when consumer interpreters loaded the PCH. The guard matches the existing pattern used forgCling/RuntimeUniversepreamble.Make
cling::outs()redirectable: AddssetOuts(raw_ostream*)API so embedders can capture or redirect cling's output stream. Passnullptrto restore the default (std::coutwrapper).Test plan
-noruntimeworks cleanly with the atexit guardsetOuts()verified in embedding test suite