Fix DeclUnloader crash with UsingShadowDecl during undo#566
Open
0xeb wants to merge 1 commit intoroot-project:masterfrom
Open
Fix DeclUnloader crash with UsingShadowDecl during undo#5660xeb wants to merge 1 commit intoroot-project:masterfrom
0xeb wants to merge 1 commit intoroot-project:masterfrom
Conversation
When unloading transactions that contain implicit template instantiations with using-shadow declarations, the DeclUnloader crashes because the introducer's shadow chain may reference already-freed declarations. Fix: enable VisitRedeclarable for UsingShadowDecl (was FIXME'd out for newer Clang) and guard removeShadowDecl() with null/containment checks to prevent use-after-free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When unloading transactions that contain implicit template instantiations with using-shadow declarations, the
DeclUnloadercrashes because the introducer's shadow chain may reference already-freed declarations.Fix: Enable
VisitRedeclarableforUsingShadowDecl(was FIXME'd out for newer Clang) and guardremoveShadowDecl()with null/containment checks to prevent use-after-free.Test plan
undo()on code withusingdeclarations crashes