[net] testParallelMergingFile: run destructors sequentially #21207
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tentative fix for the sporadic crash we get in this test. On my machine it seems to solve the issue.
pcanal
reviewed
Feb 9, 2026
| delete msg; | ||
| } | ||
|
|
||
| std::scoped_lock<std::mutex> lock(gMutex); |
Member
There was a problem hiding this comment.
If this solves the problem, we ought to understand better the underlying cause.
Test Results 21 files 21 suites 3d 14h 17m 31s ⏱️ For more details on these failures, see this check. Results for commit 8c1485f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for the sporadic crash we get in this test. On my machine it seems to solve the issue.