[ML][Python] Clean up dataloader API and avoid redundant RDF graph triggers #21214
+219
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siliataider
force-pushed
the
batchgenerator
branch
from
5a90418 to
5c1bc12
Compare
siliataider
force-pushed
the
batchgenerator
branch
from
5c1bc12 to
b3dd995
Compare
vepadulano
approved these changes
Feb 9, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thanks, changes LGTM! I have a comment for discussion.
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_ml_dataloader.py
Show resolved
Hide resolved
Test Results 22 files 22 suites 3d 13h 55m 27s ⏱️ Results for commit b3dd995. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
This PR summarizes some optimizations and cleanup, main points here:
RDataFrame::Count()calls from theRDatasetLoaderand theRChunkLoaderto reduce the number of times we trigger the RDF computation graph.Noneand explicit normalization.Checklist: