Open
Conversation
- Add Linux to supported OS list for Lima VM manager in trellis.go - Add VMType field to Instance struct (vz for macOS, qemu for Linux) - Update config.yml template with conditional logic for OS-specific settings: - macOS: vmType=vz, mountType=virtiofs, vzNAT networking - Linux: vmType=qemu, mountType=9p, user-v2 networking - Update ensureRequirements() to skip macOS version check on Linux - Fix IP() function to handle Linux QEMU networking (different interface names) - Fix version parsing in lima.go to handle Linux distro packages that output git hashes instead of semver versions - Update tests to be OS-aware Tested on Linux with Lima installed via distro package manager. VM successfully starts with QEMU, project directory mounts via 9p, and SSH/IP detection works correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Linux support for the
trellis vmcommands using Lima with QEMU.Changes
VMTypefield to Instance struct (vzfor macOS,qemufor Linux)config.ymltemplate with conditional logic for OS-specific settings:ensureRequirements()to skip macOS version check on LinuxIP()function to handle Linux QEMU networking (different interface names)Testing
Tested on Linux (Ubuntu/Arch) with Lima installed via distro package manager:
Notes
Lima supports Linux via QEMU (see lima-vm.io). This PR enables trellis-cli to use Lima on Linux systems, providing a consistent VM-based development experience across macOS and Linux.