fix: support ts7 project reference builds - #128
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughTypeScript-Go argument generation now passes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e24e67e9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (config.build && config.mode === 'write-references') { | ||
| args.push('--noEmit', 'false'); |
There was a problem hiding this comment.
Exclude tsgo-emitted reference outputs from watch deps
When dev/watch mode runs with typescript.build: true, mode: 'write-references', and clean referenced projects, this starts writing .js/.d.ts files into each TypeScript outDir. The tsgo dependency provider still watches the whole context and only excludes node_modules (plus Rspack's own output.path later), while InclusiveNodeWatchFileSystem treats added .js/.d.ts files as changes, so referenced-package output directories that are not the Rspack output directory will retrigger Rspack compilations from the checker’s own emit. Please exclude the TypeScript build artifact dirs/files when enabling emit here.
Useful? React with 👍 / 👎.
TypeScript 7's native checker always received
--noEmit, so build mode could not rebuild unbuilt project references andwrite-referenceswas ineffective.This change lets
write-referencesexplicitly enable native build output while keeping read-only modes unchanged, and adds actionable TS6310 guidance. Unit and Rspack/Webpack end-to-end coverage verify clean project-reference builds.Closes #127.