Open
Conversation
Contributor
Author
|
Was delaying PR to add the interoperability test framework with it, however, considering that this example targets master, and the test will be in dev, I think I will split the PRs in 2 instead. So this PR is ready for review now @Alxe |
alexcamposruiz
requested changes
Aug 14, 2025
Contributor
alexcamposruiz
left a comment
alexcamposruiz
left a comment
There was a problem hiding this comment.
I just realized I had feedback I hadn't submitted.
|
|
||
| ```plaintext | ||
| INFO com.rti.ndds.nddsgen.Main Running rtiddsgen version 4.3.0, please wait ... | ||
| WARN com.rti.ndds.nddsgen.emitters.FileEmitter File exists and will not be overwritten : some/path/numbers.py |
Contributor
There was a problem hiding this comment.
numbers.py is not checked in
| <value>65507</value> | ||
| </element> | ||
| <element> | ||
| <name>dds.transport.UDPv4.builtin.send_socket_buffer_size</name> |
| NEW_SOCKET_BUFFER_SIZE_STRING = "65507" | ||
|
|
||
| @staticmethod | ||
| def create_participant(domain_id: int): |
Contributor
There was a problem hiding this comment.
apply typing annotations consistently
Suggested change
| def create_participant(domain_id: int): | |
| def create_participant(domain_id: int) -> dds.DomainParticipant: |
| # DomainParticipant QoS is configured in USER_QOS_PROFILES.xml | ||
| participant = dds.DomainParticipant(domain_id) | ||
|
|
||
| # If you want to change the DomainParticipant's QoS programmatically |
Contributor
There was a problem hiding this comment.
let's do this programmatically by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding Python example for property_qos example
Checks