Spec update 2025 11 18 - #1303
Conversation
It is already declared as: > This behavior is slated to be removed in Ruby 4.0
Fixes k-takata/Onigmo#92. This fix was ported from oniguruma: kkos/oniguruma@257082d k-takata/Onigmo@b1a5445
that has not been obsolete. Partially reverting ruby/ruby#15049.
Instead of an undocumented constant.
ruby/openssl#958 changed the common logic for digest algorithm lookup: - If the argument is neither an OpenSSL::Digest instance nor a String, it is now implicitly converted to String with #to_str. This is consistent with algorithm name lookup logic in ruby/openssl for pkeys and ciphers. - If the name is not recognized, OpenSSL::Digest::DigestError is raised instead of RuntimeError. Update the specs accordingly: - Remove specs that expect #to_str not to be called. - Relax regexps matching TypeError messages. - Expect OpenSSL::Digest::DigestError instead of RuntimeError for ruby/openssl 4.0.0 and later.
This reverts commit 5b6658a406b5f1c535aed4cb68e8e18a3cbabb81. With a ruby spec fix.
for erb v4.0.4 or older
to the released version
Should fail even with `-c` option.
|
Ok what just happened... I did not merge that. |
|
Crap, I know what it did. I ran into issues running the commands and was interrupted between mri and jruby, so I pushed what I had for MRI as a PR. I intended to continue pushing the remaining updates to that branch. But when I resumed with the jruby and truffleruby spec import, it switched my ruby/spec repo back to master. I did not realize this. When I pushed I thought I was pushing more to the PR branch but it pushed everything to master. @eregon Not sure how you want to handle this. Specs have been synced only from impls to ruby/spec, not propgated back to the impls. |
That's fine, it's always the first step, and needs to be merged/pushed-to-master before propagated back to the impls anyway. |
7 participants
Dry run of spec updating with latest instructions.