Workshop Index - lazy load #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maebeale
reviewed
Dec 27, 2025
| <div class="filters-applied w-full flex gap-3 items-center"> | ||
| <h3 class="text-sm font-semibold uppercase text-gray-500 tracking-wide">Workshops (<%= @workshops.total_entries %>)</h3> | ||
| <h3 class="text-sm font-semibold uppercase text-gray-500 tracking-wide"> | ||
| Workshops (<%= @workshops&.total_entries || "" %>) |
Collaborator
There was a problem hiding this comment.
you've sold me. i think we should remove the count from the header and just include the "count_display" here.
but for workshops it's a little tricky bc we don't have a filtered and unfiltered count available from the search service. i guess we could just use Workshop.all for unfiltered.
(but prob should be if current_user.super_user Workshop.all : Workshop.published)
maebeale
reviewed
Dec 27, 2025
| <div class="flex items-start justify-between mb-6"> | ||
| <div class="pr-6"> | ||
| <h2 class="text-2xl font-semibold mb-2">Workshops (<%= @workshops_count %>)</h2> | ||
| <h2 class="text-2xl font-semibold mb-2">Workshops</h2> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Follow pattern of Resource Index and lazy load the workshop results
How did you approach the change?
Anything else to add?
screenrecording-2025-12-27_11-43-22.mp4