Draft
Conversation
Downstream Performance
KEVM
No KEVM final summary was produced. Kontrol
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
downstream-perfworkflow for KEVM and Kontrol downstream checksmasterandcurrentfor each suite as separate jobs, then compare them before publishing resultsGoal
Security and Reliability
contents: readreportjob onlypersist-credentials: falsealways()so failure diagnostics are still preservedTriggering
workflow_dispatchalways enables the selected suitespull_request, downstream jobs run only when at least one is true:perflabelbooster/**kore/**kore-rpc-types/**flake.nixdeps/**scripts/performance-tests-kevm.shscripts/performance-tests-kontrol.shscripts/compare.pyscripts/collect-downstream-perf-results.shscripts/downstream-perf-lib.sh.github/actions/downstream-perf-suite/**.github/actionlint.yaml.github/workflows/downstream-perf.ymlConfirmed Design
The intended workflow structure is:
KEVM masterKEVM currentKontrol masterKontrol currentKEVM compare, which waits forKEVM masterandKEVM currentKontrol compare, which waits forKontrol masterandKontrol currentReport PR comment, which waits for both compare jobsThe compare jobs are responsible for:
masterandcurrentThe report job is responsible for:
Workflow
flowchart TD T[Trigger] --> S[Select] S --> KM[KEVM master] S --> KC[KEVM current] S --> QM[Kontrol master] S --> QC[Kontrol current] KM --> KX[KEVM compare] KC --> KX QM --> QX[Kontrol compare] QC --> QX KX --> R[Report PR comment] QX --> RArtifact Model
In other words, the intended data flow is:
master/current raw results -> suite compare -> final suite artifact + PR commentReporting Expectations
currentversusmasterCurrent Policy Direction
origin/mastermasterandcurrentruns use the same timeout setting within a suiteTesting
bash -n)bash scripts/test-downstream-perf-lib.sh)