test(stable-mir-ui): add external UI test harness with skip management#968
Open
test(stable-mir-ui): add external UI test harness with skip management#968
Conversation
Stevengre
force-pushed
the
codex/import-stable-mir-ui-tests
branch
from
aa11396 to
40658b4
Compare
Stevengre
changed the title
Stevengre
force-pushed
the
codex/import-stable-mir-ui-tests
branch
from
40658b4 to
2d4a181
Compare
Add a parametrized pytest harness that runs kmir prove-rs against every entry in stable-mir-json's passing.tsv, with: - skip.txt for known-failing cases (2859 entries initially skipped) - --update-skip mode to shrink skip.txt by re-proving skipped cases - 300s per-test timeout via pytest-timeout - proof show output saved to tmp_path on failure for debugging New files: kmir/src/tests/external/conftest.py (--update-skip option) kmir/src/tests/external/test_stable_mir_ui_pass.py kmir/src/tests/external/data/stable-mir-ui/skip.txt Modified: Makefile (test-stable-mir-ui target) kmir/pyproject.toml (pytest-timeout dependency) kmir/uv.lock
Stevengre
force-pushed
the
codex/import-stable-mir-ui-tests
branch
from
2d4a181 to
a9c1f58
Compare
dkcumming
approved these changes
Mar 16, 2026
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
I think this is fine. Seems like passing.tsv has some ability to get out of sync with skip.txt if tests change name or are removed as rustc versions change, but this is minor and right now things are set for us. It think this is good to merge now, and until we fix the LLVM compilation issue it should stay off CI.
I will approve but I wouldn't mind @tothtamas28 option on the python if you have time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kmir prove-rsagainst every entry instable-mir-json'spassing.tsvskip.txt(2859 entries) for known-failing cases, with--update-skipmode to shrink it by re-proving skipped casespytest-timeout; proof show output saved totmp_pathon failureUsage
Test plan
make checkpasses (B011 lint fixed)origin/master