fix(rt): handle SingletonArray+Field(0)+ConstantIndex(0) in traversal#988
Open
fix(rt): handle SingletonArray+Field(0)+ConstantIndex(0) in traversal#988
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: beef218f11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Stevengre
force-pushed
the
jh/close-account-multisig-write-volatile-array
branch
2 times, most recently
from
ca049dd to
d232a5f
Compare
…napshot Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Stevengre
force-pushed
the
jh/close-account-multisig-write-volatile-array
branch
from
d232a5f to
72cb233
Compare
Stevengre
force-pushed
the
jh/close-account-multisig-write-volatile-array
branch
2 times, most recently
from
b057a45 to
490d167
Compare
Add a traversal rule that eliminates the three-element projection chain SingletonArray+Field(0)+ConstantIndex(0) on single-element Aggregates, reducing it to just Field(0). This pattern arises from pointer casts like `*const Pubkey as *mut [u8; 32]` in write_volatile calls. The three projections together mean "treat the struct as a one-element array, take field 0, index element 0" which is equivalent to just "take field 0". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Stevengre
force-pushed
the
jh/close-account-multisig-write-volatile-array
branch
from
490d167 to
9afd294
Compare
Stevengre
changed the title
Stevengre
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes stuck execution in
std::ptr::write_volatile::<[u8; 32]>caused by unhandledprojectionElemSingletonArrayin#traverseProjection.The pointer cast
*const Pubkey as *mut [u8; 32]produces the projection chainSingletonArray + Field(0) + ConstantIndex(0). This is semantically equivalent to justField(0), so a single traversal rule cancels the triplet on single-element Aggregates.