Image test - #706
Closed
stewartshea wants to merge 2 commits into
Closed
Conversation
stewartshea
marked this pull request as draft
July 22, 2026 22:57
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d86d320. Configure here.
| # `runtime_ref` dispatch input to an rw-base-runtime commit sha and | ||
| # bakes that sha into the resulting image tag suffix. | ||
| ARG BASE_IMAGE=ghcr.io/runwhen-contrib/rw-base-runtime:latest | ||
| ARG BASE_IMAGE=ghcr.io/runwhen-contrib/rw-base-runtime:7309089 |
There was a problem hiding this comment.
Runtime labels mismatch pinned base
Medium Severity
The default BASE_IMAGE is pinned to ghcr.io/runwhen-contrib/rw-base-runtime:7309089, but CI still tags images and sets io.runwhen.runtime.commit from the current rw-base-runtime@main SHA. Published metadata can claim a newer runtime than the layers in the image once main moves past 7309089.
Reviewed by Cursor Bugbot for commit d86d320. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Low Risk
Build-time base image default only; no application logic, auth, or data handling changes.
Overview
Pins the Dockerfile default
BASE_IMAGEfromrw-base-runtime:latesttorw-base-runtime:7309089, so default/local builds use that runtime commit instead of a floatinglatesttag (CI can still override viaBASE_IMAGE/ workflow inputs as documented).README.md only gains a trailing newline at EOF; no wording changes.
Reviewed by Cursor Bugbot for commit d86d320. Bugbot is set up for automated code reviews on this repo. Configure here.