Skip to content

Image test - #706

Closed
stewartshea wants to merge 2 commits into
mainfrom
image-test
Closed

Image test#706
stewartshea wants to merge 2 commits into
mainfrom
image-test

Conversation

@stewartshea

@stewartshea stewartshea commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Build-time base image default only; no application logic, auth, or data handling changes.

Overview
Pins the Dockerfile default BASE_IMAGE from rw-base-runtime:latest to rw-base-runtime:7309089, so default/local builds use that runtime commit instead of a floating latest tag (CI can still override via BASE_IMAGE / workflow inputs as documented).

README.md only gains a trailing newline at EOF; no wording changes.

Reviewed by Cursor Bugbot for commit d86d320. Bugbot is set up for automated code reviews on this repo. Configure here.

@stewartshea
stewartshea requested a review from a team as a code owner July 22, 2026 22:57
@stewartshea
stewartshea marked this pull request as draft July 22, 2026 22:57

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d86d320. Configure here.

Comment thread Dockerfile
# `runtime_ref` dispatch input to an rw-base-runtime commit sha and
# bakes that sha into the resulting image tag suffix.
ARG BASE_IMAGE=ghcr.io/runwhen-contrib/rw-base-runtime:latest
ARG BASE_IMAGE=ghcr.io/runwhen-contrib/rw-base-runtime:7309089

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime labels mismatch pinned base

Medium Severity

The default BASE_IMAGE is pinned to ghcr.io/runwhen-contrib/rw-base-runtime:7309089, but CI still tags images and sets io.runwhen.runtime.commit from the current rw-base-runtime@main SHA. Published metadata can claim a newer runtime than the layers in the image once main moves past 7309089.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d86d320. Configure here.

@stewartshea
stewartshea deleted the image-test branch July 23, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant