Add date alongside release version#2847
Merged
syphar merged 3 commits intorust-lang:masterfrom Jul 16, 2025
Merged
Conversation
github-actions
bot
added
the
S-waiting-on-review
This was referenced Jun 19, 2025
syphar
reviewed
Jun 19, 2025
GuillaumeGomez
force-pushed
the
release-date
branch
from
869baf7 to
4ae85c8
Compare
Member
Author
|
Well I did it (or thought I did). Let's see if I didn't fail it this time. |
GuillaumeGomez
force-pushed
the
release-date
branch
2 times, most recently
from
29fe7a6 to
be10101
Compare
Member
Author
|
Seems like it's still wrong. Do I need something else apart from |
Member
migrations applied in your local database? |
Member
Author
|
Everything applied, migrations done. It still generates the same file I uploaded here. |
Member
|
that's super odd, I don't like how this happens sometimes to devs. I think I remember one occasion where I had a similar issue, and solved it by using a fresh database, running the migrations, and then trying it. |
GuillaumeGomez
force-pushed
the
release-date
branch
2 times, most recently
from
690ca7b to
6ce9cac
Compare
GuillaumeGomez
force-pushed
the
release-date
branch
from
6ce9cac to
5a96371
Compare
Member
Author
|
I added a new CI task to commit the sqlx changes in our stead (if changes are detected by the CI). |
GuillaumeGomez
force-pushed
the
release-date
branch
from
5a96371 to
9db1b40
Compare
syphar
approved these changes
Jul 16, 2025
github-actions
bot
added
S-waiting-on-deploy
|
Thank you! |
syphar
removed
the
S-waiting-on-deploy
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2845.
The result looks like this:
@syphar: I also commited sqlx files but not sure if I should have.