Skip to content

archive index: increase repair-attempts for some race conditions #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syphar merged 1 commit into from
Mar 30, 2026
Merged

archive index: increase repair-attempts for some race conditions #3272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions crates/lib/docs_rs_storage/src/archive_index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ pub(crate) const ARCHIVE_INDEX_FILE_EXTENSION: &str = "index";
/// dummy size we assume in case of errors
const DUMMY_FILE_SIZE: u64 = 1024 * 1024; // 1 MiB
/// self-repair attempts
const FIND_ATTEMPTS: usize = 3;
const FIND_ATTEMPTS: usize = 5;

#[derive(Debug)]
struct Metrics {
Expand Down Expand Up @@ -1214,7 +1214,11 @@ mod tests {
fs::write(&cache_file, b"not-an-sqlite-index").await?;

let remote_index_path = format!("{ARCHIVE_NAME}.{ARCHIVE_INDEX_FILE_EXTENSION}");
let downloader = FlakyDownloader::new(remote_index_path, create_index_bytes(1).await?, 2);
let downloader = FlakyDownloader::new(
remote_index_path,
create_index_bytes(1).await?,
FIND_ATTEMPTS - 1,
);

let result = cache
.find(ARCHIVE_NAME, LATEST_BUILD_ID, FILE_IN_ARCHIVE, &downloader)
Expand Down
Loading