Skip to content

fix static asset caching after workspace refactor#3273

Merged
syphar merged 1 commit intorust-lang:mainfrom
syphar:caching
Mar 30, 2026
Merged

fix static asset caching after workspace refactor#3273
syphar merged 1 commit intorust-lang:mainfrom
syphar:caching

Conversation

@syphar
Copy link
Copy Markdown
Member

@syphar syphar commented Mar 30, 2026

the design of the in-progress-builds table was broken after deploy (#3258)

  • the BUILD_VERSION and APP_USER_AGENT include the git sha as version identifier
  • it is used as cache-buster when serving static assets (style.css and such)
  • but the docs_rs_utils subcrate was only recompiled when it was changed itself
  • so the version wasn't updated, which means the filenames weren't updated, which means they were cached in the CDN & the browser while they changed in the codebase.

Locally this would have compile time impact due to relinking. Alternatives would have been:

  • not use the git sha for cache-busting (probably doing that separately)
  • not caching static assets locally.

@syphar syphar requested a review from a team as a code owner March 30, 2026 09:03
@syphar syphar self-assigned this Mar 30, 2026
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Mar 30, 2026
@syphar syphar merged commit c1f9de8 into rust-lang:main Mar 30, 2026
10 checks passed
@syphar syphar deleted the caching branch March 30, 2026 14:40
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants